Skip to content

Conversation

@tommasini
Copy link
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Jan 15, 2026
- Add shared.yml with YAML anchors for shared configuration
- Add environment configs (prod, rc, exp) using anchor references
- Add load-yaml-config.js script to resolve cross-file anchors
- Add build.yml workflow that uses YAML anchor-based configs
- Add js-yaml dependency for YAML parsing
- Add README explaining YAML anchor approach and limitations

This proposal uses native YAML anchors and merge keys (<<) to share
configuration across environments. Anchors are defined in shared.yml
and referenced in environment configs using *anchorName syntax.

Note: Standard YAML doesn't support cross-file anchors, so a custom
loader script is needed to resolve anchors from shared.yml into
environment configs.

Co-authored-by: tomas.santos <[email protected]>
@cursor cursor bot force-pushed the proposal-2-yaml-anchors branch from d1cfa9a to f39adfb Compare January 15, 2026 15:33
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

This PR introduces a new build environment configuration system using YAML files with anchors. The changes consist entirely of:

  1. New CI/build infrastructure files:

    • A new GitHub Actions workflow (build.yml) for building the mobile app
    • New YAML configuration files for different environments (prod, rc, exp)
    • A shared YAML file with anchors for common configuration
    • A Node.js script to load and resolve YAML configurations
    • Documentation (README.md)
  2. Dev dependency addition:

    • js-yaml package added to devDependencies in package.json

Why no E2E tests are needed:

  • All changes are to build/CI infrastructure, not application code
  • No modifications to any existing app code, components, or controllers
  • The js-yaml package is a dev dependency only (not bundled in the app)
  • No changes to E2E test infrastructure or test files
  • The new workflow and configs are for building the app, not for runtime behavior
  • No user-facing features are affected

While package.json is marked as critical, the only change is adding a dev dependency for build tooling, which doesn't affect the runtime application or require E2E validation.

View GitHub Actions results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-L team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants