Skip to content

[DO NOT MERGE] Wsun/temp nightly ota v4#24717

Closed
weitingsun wants to merge 13 commits into
chore/temp-nightly-with-reusable-actionsfrom
wsun/temp-nightly-ota-v4
Closed

[DO NOT MERGE] Wsun/temp nightly ota v4#24717
weitingsun wants to merge 13 commits into
chore/temp-nightly-with-reusable-actionsfrom
wsun/temp-nightly-ota-v4

Conversation

@weitingsun
Copy link
Copy Markdown
Contributor

@weitingsun weitingsun commented Jan 16, 2026

Description

Simulator Screenshot - iPhone 16 - 2026-01-16 at 00 58 44

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

OTA and diagnostics

  • Bump OTA_VERSION to v6 in app/constants/ota.ts; version string continues to include OTA suffix in non-production
  • In AppInformation, add "Send Sentry test error" link that calls captureException for a test error
  • In Wallet, add an informational BannerAlert titled "this is ota update banner v6"

CI/GitHub Actions

  • Add composite action validate-artifact-compatibility to ensure the downloaded artifact matches runner Node version and OS
  • Add composite action restore-node-modules-permissions to reapply executable bits for node_modules binaries after artifact download

Written by Cursor Bugbot for commit 5c42709. This will update automatically on new commits. Configure here.

@weitingsun weitingsun requested review from a team as code owners January 16, 2026 08:58
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Jan 16, 2026
@weitingsun weitingsun changed the base branch from main to chore/temp-nightly January 16, 2026 08:58
cursor[bot]

This comment was marked as outdated.

@weitingsun weitingsun force-pushed the wsun/temp-nightly-ota-v4 branch from 10ca23c to 8e71509 Compare January 19, 2026 23:44
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Comment thread app/components/Views/Settings/AppInformation/index.js Outdated
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@weitingsun weitingsun changed the base branch from chore/temp-nightly to chore/temp-nightly-with-reusable-actions January 21, 2026 20:59
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: chore/temp-nightly)

All E2E tests pre-selected.

View GitHub Actions results

@weitingsun weitingsun changed the title Wsun/temp nightly ota v4 [DO NOT MERGE] Wsun/temp nightly ota v4 Jan 22, 2026
@weitingsun weitingsun closed this Jan 26, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-S team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants