chore: separate setup dependencies from EAS push job#24916
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| description: 'Name of the artifact to upload' | ||
| required: false | ||
| type: string | ||
| default: 'node-modules' |
There was a problem hiding this comment.
Also we can change the name of the node modules artifcact to include the node version and the OS name. We should pick those from the environment itself.
That way we can check it on the push-eas-update workflow if those are the same. That would prevent any undesired native (node native) behavior from happening
There was a problem hiding this comment.
this is done below when we do name: Set artifact name with node version and OS
…nt native module issues
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsAll changes in this PR are purely CI/CD infrastructure changes related to GitHub Actions workflows:
These changes:
The changes optimize CI/CD by caching node_modules artifacts and validating compatibility, but have zero impact on the mobile application behavior or E2E tests. |
|



Description
In this PR, we don't run yarn install in the EAS job. Instead we set up dependencies in a different job and attach it when we do eas push.
Workflow test: https://github.com/MetaMask/metamask-mobile/actions/runs/21225548771
Changelog
CHANGELOG entry: Added setup-dependencies to push OTA update workflow
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-265
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Separates dependency setup from the EAS update workflow and switches to artifact-based
node_modulesreuse with compatibility checks.setup-node-modules.ymlto install deps, run project setup, verify artifacts, and uploadnode_modules(versioned by Node/OS)push-eas-update.ymlto consume prebuilt artifacts for both target and base refs, generate fingerprints without reinstalling, and use artifacts in the push stepvalidate-artifact-compatibility(ensures Node/OS match) andrestore-node-modules-permissions(fixes executable bits) with verification stepsrelease-team, improvesbase_branchinput description, and updates CODEOWNERS to include the new workflowWritten by Cursor Bugbot for commit ae5bd7c. This will update automatically on new commits. Configure here.