Skip to content

feat(predict): add NBA support to sports predictions #24955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matallui merged 1 commit into from
Jan 20, 2026
Merged

feat(predict): add NBA support to sports predictions #24955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/UI/Predict/components/PredictMarket/PredictMarket.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const PredictMarket: React.FC<PredictMarketProps> = ({
entryPoint = PredictEventValues.ENTRY_POINT.PREDICT_FEED,
isCarousel = false,
}) => {
if (market.game?.league === 'nfl') {
if (market.game) {
return (
<PredictMarketSportCard
market={market}
Expand Down
2 changes: 1 addition & 1 deletion app/components/UI/Predict/constants/sports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { PredictSportsLeague } from '../types';
* 3. Add the league to this array
* 4. Add tests for the new league's slug parsing
*/
export const SUPPORTED_SPORTS_LEAGUES: PredictSportsLeague[] = ['nfl'];
export const SUPPORTED_SPORTS_LEAGUES: PredictSportsLeague[] = ['nfl', 'nba'];

export const filterSupportedLeagues = (
leagues: string[],
Expand Down
26 changes: 0 additions & 26 deletions app/components/UI/Predict/providers/polymarket/TeamsCache.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,32 +276,6 @@ describe('TeamsCache', () => {
});
});

describe('getNflTeam', () => {
beforeEach(async () => {
mockFetch.mockResolvedValueOnce({
ok: true,
json: async () => mockNflTeams,
});
await TeamsCache.getInstance().ensureLeagueLoaded('nfl');
});

it('returns NFL team by abbreviation', () => {
const cache = TeamsCache.getInstance();

const team = cache.getNflTeam('den');

expect(team?.name).toBe('Denver Broncos');
});

it('returns undefined for unknown NFL team', () => {
const cache = TeamsCache.getInstance();

const team = cache.getNflTeam('unknown');

expect(team).toBeUndefined();
});
});

describe('isLeagueLoaded', () => {
it('returns false for unloaded league', () => {
const cache = TeamsCache.getInstance();
Expand Down
4 changes: 0 additions & 4 deletions app/components/UI/Predict/providers/polymarket/TeamsCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ export class TeamsCache {
return leagueCache.get(abbreviation.toLowerCase());
}

getNflTeam(abbreviation: string): PolymarketApiTeam | undefined {
return this.getTeam('nfl', abbreviation);
}

isLeagueLoaded(league: PredictSportsLeague): boolean {
return this.cache.has(league);
}
Expand Down
2 changes: 1 addition & 1 deletion app/components/UI/Predict/types/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export type PredictCategory =
| 'politics';

// Sports league types
export type PredictSportsLeague = 'nfl';
export type PredictSportsLeague = 'nfl' | 'nba';

// Game status
export type PredictGameStatus = 'scheduled' | 'ongoing' | 'ended';
Expand Down
2 changes: 2 additions & 0 deletions app/components/UI/Predict/utils/gameParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ import {
} from '../providers/polymarket/types';

const NFL_SLUG_PATTERN = /^nfl-([a-z]+)-([a-z]+)-(\d{4}-\d{2}-\d{2})$/;
const NBA_SLUG_PATTERN = /^nba-([a-z]+)-([a-z]+)-(\d{4}-\d{2}-\d{2})$/;

const LEAGUE_SLUG_PATTERNS: Record<PredictSportsLeague, RegExp> = {
nfl: NFL_SLUG_PATTERN,
nba: NBA_SLUG_PATTERN,
};

export type TeamLookup = (
Expand Down
Loading