Skip to content

chore: ramps controller version bump#24956

Merged
georgeweiler merged 4 commits into
mainfrom
ramps-controller-4.1.0
Jan 21, 2026
Merged

chore: ramps controller version bump#24956
georgeweiler merged 4 commits into
mainfrom
ramps-controller-4.1.0

Conversation

@georgeweiler
Copy link
Copy Markdown
Contributor

@georgeweiler georgeweiler commented Jan 20, 2026

Description

Upgrade ramps controller to 4.1.0 which includes lots of methods and types needed for the V2 unified ramps flow. 4.1.0 Changelog: https://github.com/MetaMask/core/blob/main/packages/ramps-controller/CHANGELOG.md#410

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Dependency update

  • Bumps @metamask/ramps-controller to ^4.1.0 (package.json, yarn.lock)

State/schema adjustments

  • Adds paymentMethods and selectedPaymentMethod to RampsController state usages (tests, snapshots, app/util/test/initial-background-state.json)
  • Updates ramps-controller-init.test.ts to include new fields in RampsControllerState initial state

Written by Cursor Bugbot for commit 459b9fb. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-money-movement issues related to Money Movement features label Jan 20, 2026
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Jan 20, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​ramps-controller@​4.0.0 ⏵ 4.1.0100 +25100100 +25100 +7100

View full report

weitingsun
weitingsun previously approved these changes Jan 20, 2026
weitingsun
weitingsun previously approved these changes Jan 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeRamps
  • Risk Level: medium
  • AI Confidence: 80%
click to see 🤖 AI reasoning details

This PR upgrades the @metamask/ramps-controller package from v4.0.0 to v4.1.0 and adds two new state properties to the RampsController: paymentMethods (array) and selectedPaymentMethod (null).

The changes are:

  1. Package version bump (minor version - 4.0.0 → 4.1.0)
  2. New state properties added to RampsController with default empty/null values
  3. Test files and snapshots updated to reflect the new state structure
  4. Initial background state JSON updated

The changes are additive and backward compatible - they add new fields with default values rather than modifying existing behavior. However, since this affects the RampsController which is a core controller for the buy/sell (ramps) functionality, running the SmokeRamps tests is appropriate to verify that:

  • The ramps flow still works correctly with the new controller version
  • The new state properties don't cause any issues in the E2E test fixtures
  • The on-ramp and off-ramp flows function as expected

The risk is medium because:

  • It's a controller upgrade (critical path)
  • The changes affect state structure
  • But the changes are additive with safe defaults (empty array and null)

View GitHub Actions results

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.88%. Comparing base (10be529) to head (459b9fb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24956      +/-   ##
==========================================
- Coverage   79.88%   79.88%   -0.01%     
==========================================
  Files        4232     4232              
  Lines      108274   108277       +3     
  Branches    22669    22671       +2     
==========================================
+ Hits        86493    86494       +1     
- Misses      15727    15728       +1     
- Partials     6054     6055       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

@georgeweiler georgeweiler added this pull request to the merge queue Jan 21, 2026
Merged via the queue into main with commit 5813617 Jan 21, 2026
84 checks passed
@georgeweiler georgeweiler deleted the ramps-controller-4.1.0 branch January 21, 2026 01:19
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 21, 2026
@metamaskbot metamaskbot added the release-7.63.0 Issue or pull request that will be included in release 7.63.0 label Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.63.0 Issue or pull request that will be included in release 7.63.0 size-XS team-money-movement issues related to Money Movement features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants