Skip to content

chore(predict): add missing testID to PredictGameDetailsContent#24959

Merged
matallui merged 4 commits into
mainfrom
predict/fix-test-id
Jan 21, 2026
Merged

chore(predict): add missing testID to PredictGameDetailsContent#24959
matallui merged 4 commits into
mainfrom
predict/fix-test-id

Conversation

@matallui
Copy link
Copy Markdown
Contributor

@matallui matallui commented Jan 20, 2026

Description

Adds a missing testID to the SafeAreaView component in PredictGameDetailsContent to enable E2E test targeting for the Predict market details screen.

Changelog

CHANGELOG entry: null

Related issues

N/A - Quick fix for E2E test targeting.

Manual testing steps

Feature: Predict Game Details Screen

  Scenario: Screen has testID for E2E targeting
    Given the user navigates to a Predict game details screen

    When the screen renders
    Then the SafeAreaView has testID "PredictMarketDetailsSelectorsIDs.SCREEN"

Screenshots/Recordings

N/A - No visual changes.

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds missing E2E selector for the Predict market details screen.

  • Adds testID={PredictMarketDetailsSelectorsIDs.SCREEN} to the SafeAreaView in PredictGameDetailsContent
  • Updates snapshot to reflect new testID (predict-market-details-screen)

Written by Cursor Bugbot for commit 9fffc2f. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@matallui matallui added the team-predict Predict team label Jan 20, 2026
@matallui matallui marked this pull request as ready for review January 20, 2026 23:28
@matallui matallui requested a review from a team as a code owner January 20, 2026 23:28
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePredictions
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

The changes are minimal and purely additive - adding a testID attribute to a SafeAreaView component in PredictGameDetailsContent.tsx. The testID being added (PredictMarketDetailsSelectorsIDs.SCREEN) is already defined in Predict.testIds.ts and is used by the E2E test page object PredictDetailsPage.ts (in the container getter). This change improves E2E test reliability by ensuring the test selector can find the element. The snapshot update simply reflects this new testID attribute. No business logic, styling, or functionality is modified. Running SmokePredictions tests will validate that the testID is correctly placed and the Predict feature E2E tests work as expected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@matallui matallui enabled auto-merge January 21, 2026 02:01
Copy link
Copy Markdown
Contributor

@caieu caieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matallui matallui added this pull request to the merge queue Jan 21, 2026
Merged via the queue into main with commit b675b82 Jan 21, 2026
83 checks passed
@matallui matallui deleted the predict/fix-test-id branch January 21, 2026 10:41
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 21, 2026
@metamaskbot metamaskbot added the release-7.63.0 Issue or pull request that will be included in release 7.63.0 label Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.63.0 Issue or pull request that will be included in release 7.63.0 size-XS team-predict Predict team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants