Skip to content

chore(runway): cherry-pick fix: Remove userLoggedIn conditional for route definition#25658

Merged
joaoloureirop merged 1 commit into
release/7.64.0from
cherry-pick-7-64-0-2023252
Feb 4, 2026
Merged

chore(runway): cherry-pick fix: Remove userLoggedIn conditional for route definition#25658
joaoloureirop merged 1 commit into
release/7.64.0from
cherry-pick-7-64-0-2023252

Conversation

@runway-github
Copy link
Copy Markdown
Contributor

@runway-github runway-github Bot commented Feb 4, 2026

Description

This removes the userLoggedIn conditional route definition in the
navigation stack, which resolves a race condition associated with the
re-rendering of the stack. It caused users to be stuck on the LockScreen
post manual lock.

Changelog

CHANGELOG entry:

Related issues

Fixes: #25560

Manual testing steps

  • Manually lock the app from settings
  • Should land on the Login screen, not stuck on the Lock screen

Screenshots/Recordings

Before

ScreenRecording_02-02-2026.22-47-41_1.MP4

After

ScreenRecording_02-02-2026.22-47-01_1.MP4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Changes the root navigation stack so HOME_NAV is always registered, which can affect navigation state and route resolution during lock/unlock/onboarding transitions. Low code churn, but touches core app routing so regressions would surface quickly at runtime.

Overview
Removes the selectUserLoggedIn-gated conditional that only registered Routes.ONBOARDING.HOME_NAV when the wallet was unlocked.

AppFlow now always defines the HOME_NAV stack screen, preventing stack re-creation/race conditions that could leave users stuck on LockScreen after a manual lock.

Written by Cursor Bugbot for commit 78b9228. This will update automatically on new commits. Configure here.

2023252

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 4, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Feb 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 4, 2026

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.64.0)

All E2E tests pre-selected.

View GitHub Actions results

@github-actions github-actions Bot added the size-M label Feb 4, 2026
@joaoloureirop joaoloureirop enabled auto-merge (squash) February 4, 2026 16:52
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Comment thread app/components/Nav/App/App.tsx
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 4, 2026

@joaoloureirop joaoloureirop merged commit 841e0f0 into release/7.64.0 Feb 4, 2026
178 of 180 checks passed
@joaoloureirop joaoloureirop deleted the cherry-pick-7-64-0-2023252 branch February 4, 2026 18:49
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 4, 2026
@metamaskbot metamaskbot added the release-7.64.0 Issue or pull request that will be included in release 7.64.0 label Feb 6, 2026
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.64.0 on PR, as PR was cherry-picked in branch 7.64.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.64.0 Issue or pull request that will be included in release 7.64.0 size-M team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants