Skip to content

chore(runway): cherry-pick fix: background color for Perps deposit cp-7.64.0#25720

Merged
joaoloureirop merged 1 commit into
release/7.64.0from
runway-cherry-pick-7.64.0-1770310970
Feb 5, 2026
Merged

chore(runway): cherry-pick fix: background color for Perps deposit cp-7.64.0#25720
joaoloureirop merged 1 commit into
release/7.64.0from
runway-cherry-pick-7.64.0-1770310970

Conversation

@runway-github
Copy link
Copy Markdown
Contributor

@runway-github runway-github Bot commented Feb 5, 2026

Description

Fixes background color for Perps deposit. It was set to white, now it's
set back to gray.

Changelog

CHANGELOG entry: Fixes background color for Perps deposit

Related issues

Fixes:

Manual testing steps

  1. Go to Perps deposit, background is gray now, as it was before

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Small UI-only change localized to Perps’ confirmation route wrapper; main risk is unintended visual regressions (background color) across Perps confirmation flows.

Overview
Removes Perps’ custom useTheme()-driven fullscreenStyle background override when rendering Confirm in PerpsConfirmScreen, leaving only the disableSafeArea behavior controlled by showPerpsHeader.

This effectively reverts Perps deposit/confirmation screens to the default confirmation background styling instead of forcing a theme background color in this route wrapper.

Written by Cursor Bugbot for commit 17d0930. This will update automatically on new commits. Configure here.

Signed-off-by: dan437 80175477+dan437@users.noreply.github.com 42a3937

…-7.64.0 (#25567)

## **Description**
Fixes background color for Perps deposit. It was set to white, now it's
set back to gray.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Fixes background color for Perps deposit

## **Related issues**

Fixes: 

## **Manual testing steps**
1. Go to Perps deposit, background is gray now, as it was before


## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**



### **After**



<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Small, localized UI change limited to Perps confirmation screen
styling; minimal behavioral risk beyond potential visual regressions.
> 
> **Overview**
> Perps confirmations no longer pass a theme-derived `fullscreenStyle`
background override into `Confirm`; they now rely on `Confirm`’s default
container styling.
> 
> The Perps route wrapper still conditionally disables safe-area insets
based on `showPerpsHeader`, but drops the `useTheme` dependency that was
forcing a white/incorrect background.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
239fb4b. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@runway-github runway-github Bot requested a review from a team as a code owner February 5, 2026 17:03
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Feb 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2026

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.64.0)

All E2E tests pre-selected.

View GitHub Actions results

@github-actions github-actions Bot added the size-S label Feb 5, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 5, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@joaoloureirop joaoloureirop added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Feb 5, 2026
@joaoloureirop joaoloureirop merged commit ed2a205 into release/7.64.0 Feb 5, 2026
239 of 251 checks passed
@joaoloureirop joaoloureirop deleted the runway-cherry-pick-7.64.0-1770310970 branch February 5, 2026 18:31
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 5, 2026
@metamaskbot metamaskbot added the release-7.64.0 Issue or pull request that will be included in release 7.64.0 label Feb 6, 2026
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.64.0 on PR, as PR was cherry-picked in branch 7.64.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.64.0 Issue or pull request that will be included in release 7.64.0 size-S skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants