Skip to content

Perps: align Home and Markets header typography/spacing#25757

Closed
geositta wants to merge 1 commit into
mainfrom
perps/home-header-type
Closed

Perps: align Home and Markets header typography/spacing#25757
geositta wants to merge 1 commit into
mainfrom
perps/home-header-type

Conversation

@geositta

@geositta geositta commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

Description

Perps: align Home and Markets header typography/spacing

Uses TextVariant.BodyLGMedium intentionally for this header/list-item update.

In our design tokens, BodyLGMedium and HeadingMD share the same size and line-height (fontSize5, lineHeight4), but differ in weight (medium vs bold). There is currently no medium-weight heading variant in TextVariant, so BodyLGMedium is the closest token match to the Figma spec while preserving the intended hierarchy styling.

https://www.figma.com/design/Jp8owZibGXg26diIjDjVuq/Mobile-Perps?node-id=13924-14951&m=dev

https://www.figma.com/design/Jp8owZibGXg26diIjDjVuq/Mobile-Perps?node-id=12331-5993&m=dev

  1. Home section header typography mismatch
  • Before: Home section titles (e.g., Positions/Orders) used HeadingMD in places.
  • After: Home section titles use BodyLGMedium for consistent section heading style.
  • Code: PerpsHomeSection.tsx
  1. Activity header typography mismatch
  • Before: Activity title used HeadingMD.
  • After: Activity title uses BodyLGMedium in loading/empty/populated states.
  • Code: PerpsRecentActivityList.tsx, PerpsRecentActivityList.test.tsx
  1. Activity header bottom spacing inconsistency
  • Before: Activity header marginBottom: 8.
  • After: Activity header marginBottom: 12.
  1. Perps Tab header spacing logic for Positions/Orders
  • After: Explicit top/below-section spacing variants applied based on layout state.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

PerpsHomeHeaders.mov
Screenshot 2026-02-10 at 10 15 29 AM Screenshot 2026-02-10 at 10 15 49 AM Screenshot 2026-02-10 at 10 19 08 AM Screenshot 2026-02-10 at 10 29 54 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-perps Perps team label Feb 6, 2026
@github-actions github-actions Bot added the size-S label Feb 6, 2026
@geositta geositta force-pushed the perps/home-header-type branch from ab74db2 to 93d1acb Compare February 9, 2026 15:27
@geositta geositta changed the title Perps/home header type Perps: align Home and Markets header typography/spacing Feb 9, 2026
@geositta geositta force-pushed the perps/home-header-type branch 3 times, most recently from 40b91cb to fd18ec9 Compare February 10, 2026 16:53
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@geositta geositta force-pushed the perps/home-header-type branch from a4eea60 to 42dab72 Compare March 18, 2026 03:48
@github-actions github-actions Bot added the risk-low Low testing needed · Low bug introduction risk label Mar 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps, SmokeWalletPlatform, SmokeConfirmations
  • Selected Performance tags: @PerformancePreps
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only changed file is PerpsRecentActivityList.styles.ts, which affects styling of a Perps UI component. There are no logic, controller, Engine, or state management changes—only presentation-layer updates. However, this component is part of the Perps feature and rendered within the Trending section. Visual or layout regressions could impact Perps flows and their integration in Trending.

Per tag requirements:

  • SmokePerps: Required because the change is within a Perps component (Recent Activity list UI).
  • SmokeWalletPlatform: Required dependency when selecting SmokePerps, as Perps is embedded inside the Trending tab.
  • SmokeConfirmations: Required dependency when selecting SmokePerps, since Perps Add Funds flow includes on-chain confirmations.

No other areas (accounts, network abstraction, identity, snaps, ramps, swaps, multi-chain API) are impacted by a styles-only change in a Perps-specific component.

Performance Test Selection:
Although the change is styling-only, it affects a list component within the Perps feature. Layout or style changes (e.g., spacing, conditional rendering wrappers, or style recalculations) can impact list rendering performance. Running @PerformancePreps ensures no regression in Perps screen load and activity rendering performance.

View GitHub Actions results

@github-actions github-actions Bot added size-XS and removed size-S labels Mar 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud

Copy link
Copy Markdown

@geositta geositta closed this Mar 25, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk-low Low testing needed · Low bug introduction risk size-XS team-perps Perps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants