chore: Signing certificates config for build with gh actions (no impact to any existing flow)#25766
Merged
Merged
Conversation
…ate build secrets into the build yml, could be optimised hopefully; action to configure signing certificates; set secrets from config script; apply build config excepts secrets script
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
weitingsun
previously approved these changes
Feb 6, 2026
sethkfman
reviewed
Feb 6, 2026
sethkfman
reviewed
Feb 6, 2026
sethkfman
reviewed
Feb 6, 2026
sethkfman
reviewed
Feb 6, 2026
sethkfman
reviewed
Feb 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25766 +/- ##
==========================================
+ Coverage 80.70% 80.83% +0.12%
==========================================
Files 4361 4370 +9
Lines 113120 113324 +204
Branches 24093 24174 +81
==========================================
+ Hits 91296 91605 +309
+ Misses 15476 15369 -107
- Partials 6348 6350 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…flows and config; updated docs
Contributor
|
@tommasini Can you run E2E with your branch? I want to make sure we are not breaking any existing CI. |
sethkfman
reviewed
Feb 9, 2026
sethkfman
reviewed
Feb 10, 2026
sethkfman
reviewed
Feb 10, 2026
MarioAslau
previously approved these changes
Feb 10, 2026
weitingsun
approved these changes
Feb 10, 2026
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
signing certificates configuration;
main-dev working; script to generate build secrets into the build yml, could be optimised hopefully;
action to configure signing certificates;
set secrets from config script;
apply build config excepts secrets script
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Updates CI build and signing flows, including fetching and injecting signing materials/secrets at runtime, so misconfiguration could break releases or leak/omit required env vars despite the changes being mostly workflow/scripts.
Overview
Build configuration is moved and expanded.
.github/builds.ymlis removed and replaced by a root-levelbuilds.yml, now including an explicitsigningsection (AWS role/secret + Android keystore path) and a newmain-betabuild variant, plus updated GitHub Environment mappings for UAT/flask builds.GitHub Actions build pipeline now supports AWS-based code signing and more reliable env propagation. The
build.ymlworkflow reads config from rootbuilds.yml, persists applied config intoGITHUB_ENV, replaces the previous keystore action with a new composite action (.github/actions/configure-signing) that assumes an AWS role and pulls signing material from AWS Secrets Manager (Android keystore + iOS cert/profile/keychain), and adds retries/timeouts plus Android CI Gradle properties and an updated iOS simulator artifact path.Secret/config tooling is refactored to match the new workflow requirements.
apply-build-config.js,validate-build-config.js, andverify-build-config.jsare updated to use rootbuilds.yml,apply-build-config.jsadds--export-github-env,set-secrets-from-config.jsnow writes mapped secrets intoGITHUB_ENV(with multiline support), and a new maintenance scriptgenerate-build-workflow-secrets-env.js(wired viayarn build:workflow:update-secrets) regenerates the workflow’s explicit secret env list. Docs/CODEOWNERS are updated accordingly.Written by Cursor Bugbot for commit 77a734b. This will update automatically on new commits. Configure here.