Skip to content

chore: Signing certificates config for build with gh actions (no impact to any existing flow)#25766

Merged
tommasini merged 21 commits into
mainfrom
chore/gh-actions-with-certificates
Feb 11, 2026
Merged

chore: Signing certificates config for build with gh actions (no impact to any existing flow)#25766
tommasini merged 21 commits into
mainfrom
chore/gh-actions-with-certificates

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

@tommasini tommasini commented Feb 6, 2026

Description

signing certificates configuration;
main-dev working; script to generate build secrets into the build yml, could be optimised hopefully;
action to configure signing certificates;
set secrets from config script;
apply build config excepts secrets script

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Updates CI build and signing flows, including fetching and injecting signing materials/secrets at runtime, so misconfiguration could break releases or leak/omit required env vars despite the changes being mostly workflow/scripts.

Overview
Build configuration is moved and expanded. .github/builds.yml is removed and replaced by a root-level builds.yml, now including an explicit signing section (AWS role/secret + Android keystore path) and a new main-beta build variant, plus updated GitHub Environment mappings for UAT/flask builds.

GitHub Actions build pipeline now supports AWS-based code signing and more reliable env propagation. The build.yml workflow reads config from root builds.yml, persists applied config into GITHUB_ENV, replaces the previous keystore action with a new composite action (.github/actions/configure-signing) that assumes an AWS role and pulls signing material from AWS Secrets Manager (Android keystore + iOS cert/profile/keychain), and adds retries/timeouts plus Android CI Gradle properties and an updated iOS simulator artifact path.

Secret/config tooling is refactored to match the new workflow requirements. apply-build-config.js, validate-build-config.js, and verify-build-config.js are updated to use root builds.yml, apply-build-config.js adds --export-github-env, set-secrets-from-config.js now writes mapped secrets into GITHUB_ENV (with multiline support), and a new maintenance script generate-build-workflow-secrets-env.js (wired via yarn build:workflow:update-secrets) regenerates the workflow’s explicit secret env list. Docs/CODEOWNERS are updated accordingly.

Written by Cursor Bugbot for commit 77a734b. This will update automatically on new commits. Configure here.

…ate build secrets into the build yml, could be optimised hopefully; action to configure signing certificates; set secrets from config script; apply build config excepts secrets script
@tommasini tommasini requested a review from a team as a code owner February 6, 2026 11:02
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team labels Feb 6, 2026
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Feb 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Feb 6, 2026
@github-actions github-actions Bot added the size-L label Feb 6, 2026
Comment thread scripts/generate-build-workflow-secrets-env.js
weitingsun
weitingsun previously approved these changes Feb 6, 2026
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Feb 6, 2026
Comment thread builds.yml Outdated
Comment thread .github/actions/configure-signing/action.yml
Comment thread builds.yml
Comment thread .github/workflows/build.yml Outdated
Comment thread scripts/set-secrets-from-config.js
Comment thread .github/actions/configure-signing/action.yml
Comment thread .github/actions/configure-signing/action.yml
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.83%. Comparing base (fdc50e0) to head (e55608e).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25766      +/-   ##
==========================================
+ Coverage   80.70%   80.83%   +0.12%     
==========================================
  Files        4361     4370       +9     
  Lines      113120   113324     +204     
  Branches    24093    24174      +81     
==========================================
+ Hits        91296    91605     +309     
+ Misses      15476    15369     -107     
- Partials     6348     6350       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread .github/workflows/build.yml
@sethkfman
Copy link
Copy Markdown
Contributor

@tommasini Can you run E2E with your branch? I want to make sure we are not breaking any existing CI.

Comment thread builds.yml Outdated
@github-actions github-actions Bot added size-XL and removed size-L labels Feb 9, 2026
@tommasini tommasini added the skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run label Feb 10, 2026
Comment thread builds.yml Outdated
Comment thread builds.yml Outdated
MarioAslau
MarioAslau previously approved these changes Feb 10, 2026
Copy link
Copy Markdown
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini enabled auto-merge February 10, 2026 23:51
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@tommasini tommasini added this pull request to the merge queue Feb 11, 2026
Merged via the queue into main with commit 78e964f Feb 11, 2026
184 of 187 checks passed
@tommasini tommasini deleted the chore/gh-actions-with-certificates branch February 11, 2026 16:51
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 11, 2026
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 11, 2026
@metamaskbot metamaskbot added the release-7.66.0 Issue or pull request that will be included in release 7.66.0 label Feb 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

force-e2e no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.66.0 Issue or pull request that will be included in release 7.66.0 size-XL skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants