Skip to content

chore: update OTA modal UI#25867

Merged
vinnyhoward merged 5 commits into
mainfrom
chore-mdp-393-update-OTA-modal-UI
Feb 10, 2026
Merged

chore: update OTA modal UI#25867
vinnyhoward merged 5 commits into
mainfrom
chore-mdp-393-update-OTA-modal-UI

Conversation

@vinnyhoward

@vinnyhoward vinnyhoward commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Description

Update OTA modal to newest design here

  • Also fixed an issue where the MetaMask logo wouldn't alternate based on light/dark mode

Changelog

CHANGELOG entry: Updated OTA modal user interface

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TMCU-393

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

Simulator Screenshot - iPhone 17 - 2026-02-09 at 16 52 20
Simulator.Screen.Recording.-.iPhone.17.-.2026-02-09.at.16.52.38.mov

After

Simulator Screenshot - iPhone 17 - 2026-02-09 at 16 46 52
after.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Primarily UI/copy changes with a small behavioral addition (explicit close) and minimal impact on the existing reload/metrics flow.

Overview
Updates OTAUpdatesModal to the latest design-system layout: replaces the old header/scroll/button components with HeaderCompactStandard + design-system Button/Text, tweaks spacing/sizing, and adds a close affordance that dismisses the bottom sheet.

Fixes branding to switch the MetaMask wordmark based on light/dark theme via useAssetFromTheme, and updates the English modal copy (title + iOS/Android descriptions). Tests are refactored to render with providers, mock new UI/theme dependencies, and add coverage for the new close button behavior.

Written by Cursor Bugbot for commit e14a256. This will update automatically on new commits. Configure here.

@github-actions

github-actions Bot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-ux Mobile UX team label Feb 9, 2026
@github-actions github-actions Bot added the size-M label Feb 9, 2026
Comment thread app/components/UI/OTAUpdatesModal/OTAUpdatesModal.tsx

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Comment thread app/components/UI/OTAUpdatesModal/OTAUpdatesModal.test.tsx
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to the OTAUpdatesModal component, which is a self-contained UI modal that appears only when OTA updates are available. The modifications include:

  1. Design system migration: Moving from internal component library to @metamask/design-system-react-native for Button and Text components
  2. Dark mode support: Adding a white version of the MetaMask name logo for dark mode
  3. Header component swap: Replacing HeaderBase with HeaderCompactStandard (an existing component used elsewhere)
  4. Text content updates: Minor copy changes in localization file

These are purely visual/styling changes with no impact on:

  • Core wallet functionality
  • Transaction flows
  • Account management
  • Network operations
  • Any critical user paths

No E2E tests exist specifically for the OTAUpdatesModal component, and the changes don't affect any shared components that other E2E tests depend on. The unit tests have been properly updated to cover the new functionality (close button). Since this modal only appears conditionally when OTA updates are available (not during normal app usage), it doesn't intersect with any E2E test scenarios.

Performance Test Selection:
The changes are limited to a modal component (OTAUpdatesModal) that only appears when OTA updates are available. The modifications are purely visual/styling changes (design system migration, dark mode support, layout adjustments) with no impact on app startup, rendering performance, data loading, or any critical user flows. The modal is not part of the main app flow and doesn't affect account lists, login, swaps, or asset loading performance.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@MarioAslau MarioAslau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnyhoward vinnyhoward added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit dc2ce76 Feb 10, 2026
58 checks passed
@vinnyhoward vinnyhoward deleted the chore-mdp-393-update-OTA-modal-UI branch February 10, 2026 19:14
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 10, 2026
@metamaskbot metamaskbot added the release-7.66.0 Issue or pull request that will be included in release 7.66.0 label Feb 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.66.0 Issue or pull request that will be included in release 7.66.0 size-M team-mobile-ux Mobile UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants