Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
| ls -la artifacts/ || true | ||
| echo "Contents of $ARTIFACT_DIR/:" | ||
| ls -la "$ARTIFACT_DIR/" || true | ||
| exit 1 |
There was a problem hiding this comment.
Flask iOS artifact format mismatch
High Severity
Extract iOS App from artifact now requires MetaMask.app.zip inside artifacts/${{ inputs.build_type }}-${{ inputs.metamask_environment }}-MetaMask.app, but the Flask repack pipeline still uploads flask-e2e-MetaMask.app as an uncompressed .app directory. The new file check exits early, so Flask iOS smoke jobs fail before Detox starts.
|





Description
This PR attempts to fix an issue where the artifact would not install properly in the devices on E2E context.
It is unsure still but could be related to actions/upload-artifact#38
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
N/A
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Workflow-only change that alters how iOS
.appartifacts are packaged/extracted; risk is limited to CI/E2E failures if paths or unzip assumptions are wrong.Overview
Updates iOS E2E CI to upload the simulator
.appasMetaMask.app.zip(usingzip -y) to preserve symlinks thatactions/upload-artifactwould otherwise flatten and break installation.Adjusts downstream iOS workflows to unzip the artifact back into
artifacts/MetaMask.appbefore repacking/running Detox, including a sanity check and updatedPREBUILT_IOS_APP_PATH.Written by Cursor Bugbot for commit 2962470. This will update automatically on new commits. Configure here.