Skip to content

test: compresses e2e artifacts#26087

Draft
christopherferreira9 wants to merge 1 commit intomainfrom
cferreira/compress-e2e-artifacts
Draft

test: compresses e2e artifacts#26087
christopherferreira9 wants to merge 1 commit intomainfrom
cferreira/compress-e2e-artifacts

Conversation

@christopherferreira9
Copy link
Contributor

@christopherferreira9 christopherferreira9 commented Feb 13, 2026

Description

This PR attempts to fix an issue where the artifact would not install properly in the devices on E2E context.
It is unsure still but could be related to actions/upload-artifact#38

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Workflow-only change that alters how iOS .app artifacts are packaged/extracted; risk is limited to CI/E2E failures if paths or unzip assumptions are wrong.

Overview
Updates iOS E2E CI to upload the simulator .app as MetaMask.app.zip (using zip -y) to preserve symlinks that actions/upload-artifact would otherwise flatten and break installation.

Adjusts downstream iOS workflows to unzip the artifact back into artifacts/MetaMask.app before repacking/running Detox, including a sanity check and updated PREBUILT_IOS_APP_PATH.

Written by Cursor Bugbot for commit 2962470. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner February 13, 2026 19:37
@christopherferreira9 christopherferreira9 added team-qa QA team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run labels Feb 13, 2026
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

ls -la artifacts/ || true
echo "Contents of $ARTIFACT_DIR/:"
ls -la "$ARTIFACT_DIR/" || true
exit 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flask iOS artifact format mismatch

High Severity

Extract iOS App from artifact now requires MetaMask.app.zip inside artifacts/${{ inputs.build_type }}-${{ inputs.metamask_environment }}-MetaMask.app, but the Flask repack pipeline still uploads flask-e2e-MetaMask.app as an uncompressed .app directory. The new file check exits early, so Flask iOS smoke jobs fail before Detox starts.

Fix in Cursor Fix in Web

@sonarqubecloud
Copy link

@christopherferreira9 christopherferreira9 marked this pull request as draft February 16, 2026 10:11
@christopherferreira9 christopherferreira9 added the DO-NOT-MERGE Pull requests that should not be merged label Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO-NOT-MERGE Pull requests that should not be merged no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-S skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant