Skip to content

test: Add Component View Tests for Send Flow#26094

Open
davibroc wants to merge 4 commits intomainfrom
test/add-send-comp-view-test
Open

test: Add Component View Tests for Send Flow#26094
davibroc wants to merge 4 commits intomainfrom
test/add-send-comp-view-test

Conversation

@davibroc
Copy link
Contributor

@davibroc davibroc commented Feb 13, 2026

Description

Sev1 issues addressed in this PR:

Test Issue What it covers
TRON send: selecting destination account updates selection and flow moves forward #22789 #23251 TRON send: choose recipient from list, flow advances (no stuck on recipient list).
WETH send flow completes through Review without getting stuck #22357 Full path: Amount → Recipient → enter address → Review.
ERC-721 send: Amount screen shows enabled Continue and user can proceed to Recipient #12317 ERC-721 send: Continue enabled on Amount, can go to Recipient.
ERC-721 selected from Asset screen navigates to Recipient not Amount #19002 Starting Send from Asset with ERC-721 opens Recipient (not Amount).
Solana send Recipient screen does not show EVM contacts #22205 Non-EVM (Solana) send: Recipient screen has no EVM contacts.
Recipient list renders each contact with avatar #22806 Each Recipient list row (contacts) has the expected avatar.
Amount screen shows keypad and amount area visible #22702 Amount screen: amount area and keypad are visible (no overflow regression).

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Primarily adds tests and test IDs, with a small navigation initialization change that could affect deep-link/startup into the Send stack but is narrowly scoped and guarded by route params.

Overview
Adds a new Send component-view test suite covering multiple regression scenarios across chains/assets (TRON recipient selection advances, WETH send reaches Review, ERC-721 continue/navigation behavior, non-EVM recipient list filtering, recipient avatar rendering, and Amount screen layout).

Updates send navigation to honor an incoming screen param by setting initialRouteName and passing initialParams to stack screens, and adds/extends testIDs in NFT rows and recipient avatars to make the flow reliably testable. Expands component-view Engine mocks with minimal AccountsController, TransactionController, and PreferencesController state needed by the new tests.

Written by Cursor Bugbot for commit 8804ad1. This will update automatically on new commits. Configure here.

@davibroc davibroc requested a review from a team as a code owner February 13, 2026 20:58
@davibroc davibroc added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-qa QA team labels Feb 13, 2026
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.22%. Comparing base (ccaa928) to head (28e16f7).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...ents/Views/confirmations/components/UI/nft/nft.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26094      +/-   ##
==========================================
+ Coverage   81.13%   81.22%   +0.09%     
==========================================
  Files        4387     4396       +9     
  Lines      113355   113510     +155     
  Branches    24339    24374      +35     
==========================================
+ Hits        91966    92204     +238     
+ Misses      15009    14954      -55     
+ Partials     6380     6352      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes affect the send flow in the confirmations system:

  1. send.tsx - Modified the Send navigator to support initial route parameters, allowing navigation directly to specific screens (ASSET or RECIPIENT) based on route params. This is a functional change that affects how the send flow can be initiated from different entry points.

  2. nft.tsx - Added testID to NFT Pressable component for testing purposes (minor, non-functional).

  3. recipient.tsx - Added testID to recipient avatar Box component for testing purposes (minor, non-functional).

  4. send.view.test.tsx - New comprehensive unit test file with regression tests for various send flow scenarios (TRON, WETH, ERC-721, Solana, contacts).

  5. mocks.ts - Updated test mocks to support the new tests (AccountsController, PreferencesController, TransactionController).

The E2E tests in tests/smoke/confirmations/send/ directly test the send flow for native tokens, ERC20 tokens, Solana, TRON, and BTC. The SmokeConfirmations tag covers transaction sending for native tokens, ERC-20 tokens, and Solana SPL tokens, which aligns with the changes.

While the unit tests include Solana scenarios, the actual code changes (testIDs and navigation) are generic to the send flow and don't specifically change Solana functionality. The SmokeConfirmations tag is sufficient as it covers the send flow including Solana token sends.

Performance Test Selection:
The changes are primarily UI testID additions and navigation parameter handling in the send flow. These changes do not impact rendering performance, data loading, or app startup. The navigation change is a simple route parameter check that doesn't affect performance. No performance tests are needed.

View GitHub Actions results

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-L team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants