Skip to content

feat: MUSD-150 quick convert poc#26096

Draft
Matt561 wants to merge 32 commits intomainfrom
feat/musd-150-quick-convert-poc
Draft

feat: MUSD-150 quick convert poc#26096
Matt561 wants to merge 32 commits intomainfrom
feat/musd-150-quick-convert-poc

Conversation

@Matt561
Copy link
Contributor

@Matt561 Matt561 commented Feb 13, 2026

Description

Adds the first iteration of the mUSD Quick Convert feature

Changelog

CHANGELOG entry: added first iteration of the mUSD quick convert feature

Related issues

Fixes: MUSD-150: Quick convert proof of concept

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

N/A - Feature didn't exist

After

https://www.loom.com/share/78b4f9a4cf774607980622642882e702

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ed balance

Signed-off-by: Matthew Grainger <matthew.grainger@consensys.net>
@Matt561 Matt561 added the No QA Needed Apply this label when your PR does not need any QA effort. label Feb 13, 2026
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 75%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR introduces the mUSD Quick Convert feature, which is a new Earn feature for converting tokens to mUSD. The changes span multiple areas:

  1. New Earn Feature (mUSD Quick Convert): New views, components, hooks, and selectors for the Quick Convert flow. This is a new feature behind a feature flag (MM_MUSD_QUICK_CONVERT_ENABLED=false by default).

  2. Confirmations System Changes:

    • Modified info-root.tsx to route to MusdConversionInfoRoot instead of MusdConversionInfo
    • Added useConfirmationVariant hook for variant-based routing
    • Modified useFullScreenConfirmation to support FORCE_BOTTOM_SHEET_BY_VARIANT for mUSD quick convert
    • Modified confirm-component.tsx to not show full screen loader for bottom sheet confirmations
    • Modified useTransactionConfirm to handle navigation differently for full-screen vs bottom sheet mUSD conversions
    • Added new MusdMaxConversionInfo component for max conversion confirmations
    • Added RelayYouReceiveRow component
  3. Token List Changes: Updated TokenListItem and TokenListItemV2 to use renamed initiateCustomConversion method (was initiateConversion).

  4. Asset Details Changes: Changed the "Receive" button in AssetDetailsActions to a "Convert" button that navigates to the Quick Convert screen.

  5. Navigation Changes: Added new routes for Quick Convert and mUSD balances bottom sheet.

The SmokeConfirmations tag is selected because:

  • The confirmations system has been modified with new variant-based routing logic
  • New confirmation components have been added (MusdMaxConversionInfo, RelayYouReceiveRow)
  • The full-screen vs bottom sheet determination logic has been changed
  • Transaction confirmation navigation has been modified

The feature is behind a feature flag that is disabled by default, which reduces the risk of breaking existing functionality. However, the confirmations system changes could potentially affect other confirmation flows if there are regressions in the variant routing or full-screen determination logic.

No other tags are selected because:

  • The Earn/mUSD features don't have dedicated E2E test tags
  • The token list changes are minor (method rename only)
  • The asset details change is specific to mUSD and behind a feature flag
  • SmokeTrade is not selected because this is not a swap/bridge flow - it's a new mUSD conversion feature

Performance Test Selection:
This PR adds a new feature (mUSD Quick Convert) that is behind a feature flag disabled by default. The changes don't affect core app performance areas like app launch, login, or asset loading. The new screens and components are isolated to the Earn module and won't impact general app performance. The confirmations system changes are routing/logic changes rather than rendering performance changes. No performance tests are needed.

View GitHub Actions results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No QA Needed Apply this label when your PR does not need any QA effort. size-XL team-earn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant