Chore/deploy yarn install#26098
Chore/deploy yarn install#26098weitingsun wants to merge 9 commits intochore/migrate-to-build-with-github-actiongfrom
Conversation
…bile into chore/fix-ios-build
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - base branch is not main (base: chore/migrate-to-build-with-github-actiong) All E2E tests pre-selected. |
| timeout_minutes: 10 | ||
| max_attempts: 3 | ||
| retry_wait_seconds: 30 | ||
| command: yarn pod:install |
There was a problem hiding this comment.
Pod install retry path is bypassed
Medium Severity
setup-dependencies runs yarn setup:github-ci --build-ios --no-build-android, and setup.mjs already performs yarn pod:install for iOS. That means CocoaPods installation happens before the retry-wrapped pod step, so transient pod failures in setup:github-ci fail the job without using retry logic.
| yarn setup:github-ci --build-ios --no-build-android | ||
| else | ||
| yarn setup:github-ci --no-build-ios | ||
| fi |
There was a problem hiding this comment.
Build type defaults to main in setup
Medium Severity
setup-dependencies runs yarn setup:github-ci before Apply build config, so METAMASK_BUILD_TYPE is unset during setup. build-inpage-bridge then builds app/core/InpageBridgeWeb3.js with the default main app ID instead of flask-specific values, and that generated artifact is reused in the build job.
|




Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Moderate risk because it substantially changes CI build dependency/setup flow across iOS and Android, which can cause build/signing regressions. App change is low impact but introduces an additional env-driven parse/render path.
Overview
Reworks the GitHub Actions mobile build pipeline by adding a new
setup-dependenciesjob (per-platform runner) that installs JS deps, runsyarn setup:github-ci, installs iOS Pods, verifies required artifacts, then uploads a tarball so thebuildjob can download/extractnode_modules(preserving symlinks) instead of reinstalling.The
buildjob is updated to consume and validate these artifacts, removes the previous Ruby/CocoaPods install+cache steps, adds iOS keychain cleanup before signing, and writesios/.xcode.env.localto pinNODE_BINARYfor Xcode scripts.In-app, the Settings
AppInformationscreen now parsesprocess.env.REMOTE_FEATURE_FLAG_DEFAULTSand (when environment info is revealed) displays the build-time remote feature-flag default values for easier debugging.Written by Cursor Bugbot for commit 7ef86cb. This will update automatically on new commits. Configure here.