refactor: Updated Headers for Settings - Experimental pages#26411
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…aMask/metamask-mobile into header/settings-experimental
…to header/settings-experimental
…to header/settings-experimental
…to header/settings-experimental
…aMask/metamask-mobile into header/settings-experimental
3050bc1
…to header/settings-experimental
…aMask/metamask-mobile into header/settings-experimental
…to header/settings-experimental
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
Since there are no E2E tests that cover these specific screens and the changes are purely UI refactoring using an established component pattern, no E2E test tags are needed. Performance Test Selection: |
Description
This PR updates the Experimental Settings and WalletConnect Sessions screens to use inline
HeaderCompactStandardinstead of stack navbar options.Reason for change: Align Settings-related experimental screens with the app’s header pattern: simple back + title screens should use
HeaderCompactStandard(or equivalent) rendered inline, with the stack header hidden, for consistent layout and safe area handling.What changed:
ExperimentalSettingsandRoutes.WALLET.WALLET_CONNECT_SESSIONS_VIEW(WalletConnectSessions), replacedoptions={...navigationOptions}withoptions={{ headerShown: false }}so both screens control their own headers.useEffectandgetNavigationOptionsTitle; removeduseThemeusage for nav options. Wrapped the screen inSafeAreaView(edges: top) and added inlineHeaderCompactStandardwithtitle={strings('app_settings.experimental_title')},onBack={handleBack}, and testIDs fromExperimentalView.testIds. Scroll content moved into aScrollViewwith newstyles.content(wrapper keeps background; content has padding).wrapperkeepsbackgroundColorandflex: 1; addedcontentwithflex: 1,padding: 16,paddingBottom: 48for the scrollable area below the header.EXPERIMENTAL_SETTINGS_HEADER,EXPERIMENTAL_SETTINGS_BACK_BUTTON,WALLET_CONNECT_SESSIONS_HEADER,WALLET_CONNECT_SESSIONS_BACK_BUTTONfor header and back button tests.goBackinstead ofsetOptions. Added tests: “renders inline HeaderCompactStandard with title and back button”, “calls navigation.goBack when back button is pressed”. Removed redundant comments in other tests. Snapshot updated.getNavigationOptionsTitle,updateNavBar, andcomponentDidUpdate; switched toSafeAreaViewfromreact-native-safe-area-contextwithedges={['top']}. Added inlineHeaderCompactStandardwith title “Wallet Connect dapps”,onBack, and testIDs fromExperimentalView.testIds.Changelog
This PR is not end-user-facing (header presentation aligned with design; same screen content and behavior).
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/issues?jql=issueKey%20in%20(DSYS-357%2CDSYS-358%2CDSYS-359%2CDSYS-360)&selectedIssue=DSYS-360
Manual testing steps
Screenshots/Recordings
Before
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2026-02-22.at.18.36.47.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
UI-only navigation refactor limited to
ExperimentalSettingsandWalletConnectSessions; main risk is minor regressions in back navigation/safe-area/header visibility on those screens.Overview
Moves
ExperimentalSettingsandWalletConnectSessionsoff stack-provided navbar options and onto an inlineHeaderCompactStandard, withMainNavigatorexplicitly settingheaderShown: falsefor both routes.Wraps both screens in
react-native-safe-area-contextSafeAreaView(with bottom additive inset) and updatesExperimentalSettingslayout to separatewrappervs scrollcontentpadding. Adds new header/backtestIDs and extends unit tests + snapshots to verify header rendering andnavigation.goBackbehavior.Written by Cursor Bugbot for commit 3f4964f. This will update automatically on new commits. Configure here.