Skip to content

feat: confirmation page design changes for token transfers#26996

Merged
jpuri merged 8 commits into
mainfrom
conf_page_design_update
Mar 9, 2026
Merged

feat: confirmation page design changes for token transfers#26996
jpuri merged 8 commits into
mainfrom
conf_page_design_update

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Mar 4, 2026

Description

Changes in title and token hero section of confirmation page for transfers (including send).

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/7046

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Screenshot 2026-03-04 at 9 04 51 PM Screenshot 2026-03-04 at 9 35 48 PM Screenshot 2026-03-06 at 2 09 58 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Medium risk because it changes the transaction confirmation UI (title visibility and hero layout) in a critical user flow, which could affect clarity or regress rendering across states (loading/skeleton, token vs NFT). No signing or transaction data logic is modified.

Overview
Transfer confirmation header UI is redesigned. Transfer confirmations now render HeroRow in a new layout="horizontal" mode that shows a localized “Sending” label with left-aligned details and the asset icon/badge on the right, including matching horizontal skeleton states.

Title behavior is simplified for transfers. The transfer flow sets an empty navbar title and Title no longer renders a “Transfer request” title (and avoids rendering any fallback title while transaction metadata is still loading). Token/NFT hero components and the token avatar-with-network-badge were updated to support the new layout (including configurable avatar size and tooltip behavior for rounded amounts), with tests and the new confirm.label.sending locale string added.

Written by Cursor Bugbot for commit f656955. This will update automatically on new commits. Configure here.

@jpuri jpuri added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Mar 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri enabled auto-merge March 4, 2026 14:23
@github-actions github-actions Bot added the size-M label Mar 4, 2026
@jpuri jpuri requested a review from a team as a code owner March 4, 2026 16:06
@jpuri
Copy link
Copy Markdown
Contributor Author

jpuri commented Mar 4, 2026

@metamaskbot update-mobile-fixture

Comment thread app/components/Views/confirmations/components/title/title.tsx
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread app/components/Views/confirmations/components/hero-nft/hero-nft.test.tsx Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR modifies the confirmation UI components for transfer transactions. The changes include:

  1. New horizontal layout for hero components: Added a layout prop to HeroToken, HeroNft, and HeroRow components with a new "horizontal" layout option.

  2. Transfer confirmation UI changes:

    • Navbar title changed from "Review" to empty string
    • Hero row now uses horizontal layout
    • Added "Sending" label to the horizontal layout
  3. Title component changes: Transfer transactions no longer show a title (returns null instead of "Transfer request"), with a guard to avoid rendering fallback title while transaction metadata is loading.

  4. Style and localization updates: New styles for horizontal layout and new "sending" label in en.json.

These changes directly affect the confirmation flow for transfer transactions (simpleSend, tokenMethodTransfer, tokenMethodTransferFrom, tokenMethodSafeTransferFrom). The SmokeConfirmations tag is the appropriate choice as it covers transaction confirmation UI, token transfers, and the confirmation system.

The changes are UI/UX focused with no impact on core transaction logic, so the risk is medium. Unit tests have been updated to cover the new functionality.

Performance Test Selection:
These changes are purely UI/UX layout and styling changes for the confirmation screen. They don't affect data loading, state management, list rendering performance, or any critical performance paths. The changes add a new layout option for hero components and modify the title display logic, but don't introduce any performance-impacting code changes.

View GitHub Actions results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 68
Missing keys 11
Type mismatches 0
Value mismatches 7 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 6, 2026

@jpuri jpuri added this pull request to the merge queue Mar 9, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 9, 2026
@jpuri jpuri added this pull request to the merge queue Mar 9, 2026
Merged via the queue into main with commit c4b9c3d Mar 9, 2026
95 checks passed
@jpuri jpuri deleted the conf_page_design_update branch March 9, 2026 13:58
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 9, 2026
@metamaskbot metamaskbot added the release-7.70.0 Issue or pull request that will be included in release 7.70.0 label Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.70.0 Issue or pull request that will be included in release 7.70.0 size-M team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants