feat: confirmation page design changes for token transfers#26996
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
@metamaskbot update-mobile-fixture |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
These changes directly affect the confirmation flow for transfer transactions (simpleSend, tokenMethodTransfer, tokenMethodTransferFrom, tokenMethodSafeTransferFrom). The SmokeConfirmations tag is the appropriate choice as it covers transaction confirmation UI, token transfers, and the confirmation system. The changes are UI/UX focused with no impact on core transaction logic, so the risk is medium. Unit tests have been updated to cover the new functionality. Performance Test Selection: |
The committed fixture schema is out of date. To update, comment: |
|



Description
Changes in title and token hero section of confirmation page for transfers (including send).
Changelog
CHANGELOG entry:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/7046
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it changes the transaction confirmation UI (title visibility and hero layout) in a critical user flow, which could affect clarity or regress rendering across states (loading/skeleton, token vs NFT). No signing or transaction data logic is modified.
Overview
Transfer confirmation header UI is redesigned. Transfer confirmations now render
HeroRowin a newlayout="horizontal"mode that shows a localized “Sending” label with left-aligned details and the asset icon/badge on the right, including matching horizontal skeleton states.Title behavior is simplified for transfers. The transfer flow sets an empty navbar title and
Titleno longer renders a “Transfer request” title (and avoids rendering any fallback title while transaction metadata is still loading). Token/NFT hero components and the token avatar-with-network-badge were updated to support the new layout (including configurable avatar size and tooltip behavior for rounded amounts), with tests and the newconfirm.label.sendinglocale string added.Written by Cursor Bugbot for commit f656955. This will update automatically on new commits. Configure here.