fix: MUSD-400 fixed spam clicks on bottom sheet component causing it to navigate back

[Matt561]

Description

Fixes a bug where rapidly tapping UI elements that open a BottomSheet (e.g. PayWithRow → PayWithModal) could cause an extra navigation.goBack() to fire after the BottomSheet's screen was already popped. For the mUSD conversion flow, this caused the onReject to not be called leaving stale pending approvals and incorrectly disabling the Quick Convert view.

Adds a navigation.isFocused() guard before goBack() in BottomSheet.onCloseCB so that stale close callbacks from Reanimated animations become no-ops when the screen is no longer active.

Changes

• BottomSheet.tsx: Guard navigation.goBack() with navigation.isFocused() check in onCloseCB

Changelog

CHANGELOG entry: fixed BottomSheet dismissing the wrong screen when rapidly opened and closed, which could leave mUSD conversion confirmation flows in a blocked state with unrejected pending approvals

Related issues

Fixes: MUSD-400: Quick convert buttons disabled after switching payment tokens quickly on custom convert screen

Manual testing steps

Feature: mUSD conversion BottomSheet dismiss does not break Quick Convert view

  Scenario: user spam-taps Pay With on the mUSD custom conversion screen
    Given user is on the mUSD Quick Convert view with convertible stablecoin balances
    And user taps the Edit (pencil) icon on a token row to open the custom conversion screen

    When user rapidly taps the Pay With row and continues tapping as the Pay With modal opens
    Then the Pay With modal closes and the user remains on the custom conversion screen
    And the user is not navigated back to the Quick Convert view
    And the Quick Convert view does not show a loading spinner or disabled action buttons

Screenshots/Recordings

Before

Convert.buttons.freeze.1.mp4

After

Screen_Recording_20260304_170111_MetaMask.mp4

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Touches shared BottomSheet close/back-handling behavior, so regressions could affect navigation dismissal across many screens, though the change is a narrow isFocused() guard.

Overview
Prevents rapid open/close interactions from popping the wrong screen by guarding BottomSheet's onClose and Android hardware back handling with navigation.isFocused() before attempting dismissal.

Updates a broad set of Jest navigation mocks/snapshots to include isFocused() so tests align with the new BottomSheet navigation dependency.

^{Written by Cursor Bugbot for commit 583f2a0. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions
• Selected Performance tags: None (no tests recommended)
• Risk Level: high
• AI Confidence: 85%

click to see 🤖 AI reasoning details

E2E Test Selection:
The change modifies the shared BottomSheet component used across the app. It introduces navigation.isFocused() guards before calling navigation.goBack() and before handling Android hardware back presses. Since BottomSheet underpins confirmations, network selectors, account selectors, trade flows, ramps, card flows, perps, predictions, multi-chain permission sheets, and various modals, this affects core navigation and dismissal behavior globally.

Potential risks include:

• Bottom sheets not closing when expected (navigation focus edge cases)
• Duplicate or skipped navigation events
• Android back button behavior regressions
• Broken confirmation or permission flows

Because BottomSheet is a shared foundational UI component, the blast radius is high and spans nearly all major wallet flows. To safely validate navigation and dismissal behavior across critical user journeys, a broad E2E sweep is required.

All dependent tag requirements have been respected:

• SmokeTrade includes SmokeConfirmations
• SmokeCard includes SmokeTrade and SmokeConfirmations
• SmokePerps includes SmokeWalletPlatform and SmokeConfirmations
• SmokePredictions includes SmokeWalletPlatform and SmokeConfirmations
• SmokeMultiChainAPI includes SmokeNetworkAbstractions and SmokeNetworkExpansion
• SmokeNetworkExpansion includes SmokeConfirmations

Performance Test Selection:
The change only adds navigation focus guards and logging inside the BottomSheet component. There are no changes to rendering logic, list performance, controller state management, data fetching, or startup flows. No measurable performance impact is expected.

View GitHub Actions results

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
9 value mismatches detected (expected — fixture represents an existing user).
View details

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud