Skip to content

chore: update Accounts CO#27089

Merged
gantunesr merged 7 commits into
mainfrom
gar/chore/accounts-codeowners
Mar 6, 2026
Merged

chore: update Accounts CO#27089
gantunesr merged 7 commits into
mainfrom
gar/chore/accounts-codeowners

Conversation

@gantunesr
Copy link
Copy Markdown
Member

@gantunesr gantunesr commented Mar 5, 2026

Description

Update Accounts CO

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1260

Manual testing steps

Not applicable

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk because changes are limited to CODEOWNERS updates and import-path adjustments after reorganizing controller init modules, with no functional logic changes.

Overview
Updates .github/CODEOWNERS to assign the Accounts team ownership of additional Engine controller directories (e.g., multichain-account-service, snap-keyring, keyring-controller, storage-service) and expands multichain account path patterns.

Adjusts Engine.ts and related controller init tests to import snap-keyring, keyring-controller, and storage-service init modules from their new subdirectories.

Written by Cursor Bugbot for commit e3e1512. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-accounts-framework Accounts team label Mar 5, 2026
@github-actions github-actions Bot added the size-S label Mar 5, 2026
@gantunesr gantunesr marked this pull request as ready for review March 6, 2026 00:27
@gantunesr gantunesr requested a review from a team as a code owner March 6, 2026 00:27
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR is a pure file reorganization/refactoring with no functional code changes. The changes involve:

  1. Engine.ts: Only import path updates - moving from flat controller files to subdirectory structure
  2. keyring-controller-init.ts: Moved to keyring-controller/ subdirectory with updated relative imports
  3. snap-keyring-builder-init.ts: Moved to snap-keyring/ subdirectory with updated relative imports
  4. storage-service-init.ts: Moved to storage-service/ subdirectory with updated relative imports
  5. Test files: Same reorganization with updated imports
  6. CODEOWNERS: Added ownership entries for the new directories

No functional changes were made - no initialization order changes, no messenger configuration changes, no state schema changes, and no dependency changes. The controllers still work exactly the same way, just organized into subdirectories.

However, since these involve critical Phase 2 controllers (KeyringController is foundational for all account/transaction operations), I'm selecting SmokeAccounts as a minimal sanity check to verify the app still initializes correctly and basic account functionality works after the refactoring. This provides confidence that the import path changes don't break anything at runtime.

Performance Test Selection:
This PR contains only file reorganization and import path updates with no functional code changes. There are no changes to UI rendering, data loading, state management, or any code paths that could impact app performance. The controllers function identically, just from different file locations. No performance tests are needed.

View GitHub Actions results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 68
Missing keys 11
Type mismatches 0
Value mismatches 7 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 6, 2026

@gantunesr gantunesr enabled auto-merge March 6, 2026 13:57
@gantunesr gantunesr added this pull request to the merge queue Mar 6, 2026
Merged via the queue into main with commit 80c5a63 Mar 6, 2026
92 checks passed
@gantunesr gantunesr deleted the gar/chore/accounts-codeowners branch March 6, 2026 15:41
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 6, 2026
@metamaskbot metamaskbot added the release-7.70.0 Issue or pull request that will be included in release 7.70.0 label Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.70.0 Issue or pull request that will be included in release 7.70.0 size-S team-accounts-framework Accounts team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants