Skip to content

feat: Updating mUSD conversion copy to reflect annualized bonus and claim timeline cp-7.69.0#27097

Merged
Matt561 merged 4 commits into
mainfrom
feat/musd-392-update-annual-bonus-copy
Mar 6, 2026
Merged

feat: Updating mUSD conversion copy to reflect annualized bonus and claim timeline cp-7.69.0#27097
Matt561 merged 4 commits into
mainfrom
feat/musd-392-update-annual-bonus-copy

Conversation

@Matt561
Copy link
Copy Markdown
Contributor

@Matt561 Matt561 commented Mar 5, 2026

Description

This PR updates mUSD conversion copy to reflect annualized bonus and claim timeline.

Changelog

CHANGELOG entry: updated mUSD conversion copy to reflect annualized bonus and claim timeline

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Education screen

image

Custom convert navbar tooltip

image

Claimable bonus tooltip

Custom convert
image

Quick conver
image

Asset details CTA

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: primarily copy/translation key updates plus minor UI tooltip/toast rendering changes (adds a terms link and an extra success-toast description) with no changes to conversion logic or data handling.

Overview
Updates mUSD conversion user-facing messaging to consistently describe the incentive as an annualized bonus and to communicate that the bonus becomes claimable within about a day.

This refreshes strings across the education screen, quick convert header, asset overview CTA, claimable bonus tooltip, and conversion success toast (now includes a secondary description line), and adjusts the confirmation PercentageRow tooltip to include a tappable “Terms apply” link to the bonus terms URL. Tests are updated to match the new copy and label formatting.

Written by Cursor Bugbot for commit 388fcc0. This will update automatically on new commits. Configure here.

@Matt561 Matt561 requested review from a team as code owners March 5, 2026 21:45
@Matt561 Matt561 added No QA Needed Apply this label when your PR does not need any QA effort. team-earn labels Mar 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label Mar 5, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread locales/languages/en.json
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2026

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 68
Missing keys 11
Type mismatches 1
Value mismatches 9 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are primarily copy/text updates and minor UI enhancements to the mUSD conversion feature:

  1. Localization changes (en.json): Updated tooltip text, changed "receive up to a X% bonus" to "earn up to a X% annualized bonus", added new toast description, renamed parameter from apy to percentage

  2. MusdQuickConvertView: Simple parameter rename from apy to percentage in string interpolation

  3. useEarnToasts.tsx: Added a secondary description text to the success toast for mUSD conversion delivery

  4. percentage-row.tsx: Added a clickable "Terms apply" link in the tooltip that opens the bonus terms of use URL

The mUSD conversion E2E tests are tagged with SmokeWalletPlatform (tests/smoke/wallet/musd-conversion-happy-path.spec.ts). While there are also mUSD-related tests in SmokeTrade (gasless swap) and SmokeRamps (sell mUSD deeplink), those tests don't directly exercise the changed components (toast messages, tooltip content, or the quick convert view copy).

The changes are low risk because:

  • They are primarily text/copy changes
  • The toast enhancement adds a secondary description without changing existing behavior
  • The tooltip link addition is a minor UI enhancement
  • All unit tests have been updated to match the new behavior

SmokeWalletPlatform is sufficient to validate the mUSD conversion flow which exercises the changed components.

Performance Test Selection:
The changes are purely copy/text updates and minor UI enhancements (adding a secondary toast description and a clickable link in a tooltip). These changes do not affect rendering performance, data loading, state management, or any critical user flows that would impact app performance. No performance tests are needed.

View GitHub Actions results

@Matt561 Matt561 enabled auto-merge March 5, 2026 22:42
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 5, 2026

@Matt561 Matt561 added this pull request to the merge queue Mar 6, 2026
Merged via the queue into main with commit f9325e3 Mar 6, 2026
79 of 82 checks passed
@Matt561 Matt561 deleted the feat/musd-392-update-annual-bonus-copy branch March 6, 2026 09:23
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 6, 2026
@metamaskbot metamaskbot added the release-7.70.0 Issue or pull request that will be included in release 7.70.0 label Mar 6, 2026
@joaoloureirop joaoloureirop changed the title feat: Updating mUSD conversion copy to reflect annualized bonus and claim timeline feat: Updating mUSD conversion copy to reflect annualized bonus and claim timeline cp-7.69.0 Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.70.0 Issue or pull request that will be included in release 7.70.0 size-M team-earn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants