feat: fix button label for action button clicked event cp-7.69.0#27117
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
These are low-risk changes because:
Selected tags:
Performance Test Selection: |
The committed fixture schema is out of date. To update, comment: |
|



Description
The sticky Buy and Sell buttons on the token details page were both firing ACTION_BUTTON_CLICKED with button_label: "Swap", making it impossible to distinguish between the two actions in Mixpanel.
Changes:
handleBuyPressnow passesbutton_label: "Buy"andhandleSellPresspassesbutton_label: "Sell"Changelog
CHANGELOG entry: updated event property for ACTION_BUTTON_CLICKED
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: changes only analytics event properties by threading an optional
buttonLabelthrough navigation helpers; swap/bridge navigation behavior is unchanged due to a default fallback.Overview
Fixes token details Buy/Sell sticky buttons reporting
ACTION_BUTTON_CLICKEDwithbutton_label: "Swap".useSwapBridgeNavigationnow accepts an optionalbuttonLabelingoToNativeBridge/goToSwapsand uses it fortrackActionButtonClick(defaulting to the existing Swap label), anduseTokenActionspasses the correct localized Buy/Sell labels; tests were updated to assert the new arguments.Written by Cursor Bugbot for commit 8c1b45d. This will update automatically on new commits. Configure here.