Skip to content

chore: increase js bundle to 53#27135

Merged
tommasini merged 1 commit into
mainfrom
chore/increase-js-bundle-to-53
Mar 6, 2026
Merged

chore: increase js bundle to 53#27135
tommasini merged 1 commit into
mainfrom
chore/increase-js-bundle-to-53

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

@tommasini tommasini commented Mar 6, 2026

Description

Increase JS bundle 1 MB

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: workflow-only change that just relaxes the CI bundle-size gate by 1 unit and doesn’t affect runtime code.

Overview
CI bundle-size gating has been relaxed slightly. The js-bundle-size-check step in .github/workflows/ci.yml now allows an iOS main.jsbundle size threshold of 53 instead of 52 when running ./scripts/js-bundle-stats.sh.

Written by Cursor Bugbot for commit 3c0f0a4. This will update automatically on new commits. Configure here.

@tommasini tommasini requested a review from a team as a code owner March 6, 2026 15:20
@tommasini tommasini added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Mar 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Mar 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change is a simple CI configuration adjustment that increases the iOS JS bundle size limit from 52 MB to 53 MB in the CI workflow. This is purely an administrative/infrastructure change that:

  1. Does not modify any application code
  2. Does not change any test infrastructure or test files
  3. Does not affect any user-facing functionality
  4. Simply adjusts a threshold value to allow a slightly larger bundle to pass CI checks

This type of change has zero impact on application behavior and requires no E2E test validation. The bundle size check script (js-bundle-stats.sh) is a simple file size comparison utility that runs during CI to ensure the bundle doesn't exceed a specified limit. Increasing this limit from 52 to 53 MB is a routine maintenance task that doesn't warrant running any E2E tests.

Performance Test Selection:
This change only adjusts a bundle size threshold in CI configuration. It does not modify any application code, UI components, data loading logic, or any code paths that could impact app performance. No performance tests are needed for this administrative CI change.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 6, 2026

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tommasini tommasini added this pull request to the merge queue Mar 6, 2026
Merged via the queue into main with commit 2ed7bb0 Mar 6, 2026
88 checks passed
@tommasini tommasini deleted the chore/increase-js-bundle-to-53 branch March 6, 2026 17:56
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 6, 2026
@metamaskbot metamaskbot added the release-7.70.0 Issue or pull request that will be included in release 7.70.0 label Mar 6, 2026
@metamaskbot metamaskbot added release-7.69.0 Issue or pull request that will be included in release 7.69.0 and removed release-7.70.0 Issue or pull request that will be included in release 7.70.0 labels Mar 16, 2026
@metamaskbot
Copy link
Copy Markdown
Collaborator

Missing release label release-7.69.0 on PR. Adding release label release-7.69.0 on PR and removing other release labels(release-7.70.0), as PR was cherry-picked in branch 7.69.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-XS team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants