chore(runway): cherry-pick feat: MUSD-394 add generic transaction fee row to conversion confirmations#27136
Merged
joaoloureirop merged 1 commit intoMar 6, 2026
Conversation
… row to conversion confirmations (#27091) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Replace the mUSD-specific `NetworkFeeRow` with the generic `TransactionFeeRow` on conversion confirmations, and update the transaction fee tooltip copy to clarify that no MetaMask fee applies. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: replaced mUSD conversion-specific network fee row with the generic transaction fee row and updated fee tooltip copy ## **Related issues** Fixes: [MUSD-394: Add generic "Transaction Fee" row to conversion confirmations](https://consensyssoftware.atlassian.net/browse/MUSD-394) ## **Manual testing steps** ```gherkin Feature: Generic transaction fee row for mUSD conversions Scenario: user views fee breakdown on mUSD conversion confirmation Given user is on the mUSD conversion confirmation screen When user views the fee details Then the generic transaction fee row is displayed instead of a network-fee-only row ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** mUSD conversions only displayed the "Network Fee" <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ### Custom conversion input <img width="493" height="1014" alt="image" src="https://github.com/user-attachments/assets/10ab06f2-ff3c-4039-85c9-da636fef70fc" /> <img width="493" height="1014" alt="image" src="https://github.com/user-attachments/assets/015e4775-64e6-42c7-b303-4142d12a7132" /> ### "Max" convert bottom sheet <img width="493" height="1014" alt="image" src="https://github.com/user-attachments/assets/e60de70d-94ec-4da8-9cf1-070e18b05f26" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > UI-only confirmation changes to fee row rendering and tooltip copy; main risk is mismatched testIDs or fee display expectations in mUSD conversion flows. > > **Overview** > **mUSD conversion confirmations now use the generic `TransactionFeeRow`** instead of the mUSD-specific `NetworkFeeRow`, so conversions show the same combined transaction fee total (network + provider + MetaMask) and tooltip breakdown as other pay flows. > > Removes the `ConfirmationRowComponentIDs.NETWORK_FEE` selector and deletes the associated `musdConversion` network-fee row/skeleton tests; updates English tooltip copy to clarify *no MetaMask fee applies* for mUSD conversions (and fixes `mUSD` casing in the predict-withdraw tooltip). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit dd076d6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.68.0) All E2E tests pre-selected. |
joaoloureirop
approved these changes
Mar 6, 2026
metamaskbot
added
the
release-7.68.0
Collaborator
|
No release label on PR. Adding release label release-7.68.0 on PR, as PR was cherry-picked in branch 7.68.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the mUSD-specific
NetworkFeeRowwith the genericTransactionFeeRowon conversion confirmations, and update thetransaction fee tooltip copy to clarify that no MetaMask fee applies.
Changelog
CHANGELOG entry: replaced mUSD conversion-specific network fee row with
the generic transaction fee row and updated fee tooltip copy
Related issues
Fixes: MUSD-394: Add generic "Transaction Fee" row to conversion
confirmations
Manual testing steps
Screenshots/Recordings
Before
mUSD conversions only displayed the "Network Fee"
After
Custom conversion input
"Max" convert bottom sheet
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
UI-only confirmation changes to fee row rendering and tooltip copy;
main risk is mismatched testIDs or fee display expectations in mUSD
conversion flows.
Overview
mUSD conversion confirmations now use the generic
TransactionFeeRowinstead of the mUSD-specificNetworkFeeRow, soconversions show the same combined transaction fee total (network +
provider + MetaMask) and tooltip breakdown as other pay flows.
Removes the
ConfirmationRowComponentIDs.NETWORK_FEEselector anddeletes the associated
musdConversionnetwork-fee row/skeleton tests;updates English tooltip copy to clarify no MetaMask fee applies for
mUSD conversions (and fixes
mUSDcasing in the predict-withdrawtooltip).
Written by Cursor
Bugbot for commit
dd076d6. This will update automatically
on new commits. Configure
here.