test: moves hardcoded testIds into dedicated files - accounts

[christopherferreira9]

Description

This PR moves hardcoded strings into dedicated *.testIds.ts files so they can be used through the multiple test parts to avoid duplication.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Low risk refactor that only replaces hardcoded testID strings with exported constants; main risk is breaking E2E/unit selectors if any IDs changed (they appear unchanged).

Overview
Moves several hardcoded React Native testID strings into new dedicated *.testIds.ts modules and updates components to reference these constants.

This standardizes selectors for multichain account list cells (AccountListCell, ExternalAccountCell), Backup & Sync toggles (BackupAndSyncToggle, BackupAndSyncFeaturesToggles), and Smart Account UI (SmartAccountModal, SmartAccountNetworkList, LearnMoreBottomSheet) without changing UI behavior.

^{Written by Cursor Bugbot for commit fdbbda0. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeIdentity, SmokeWalletPlatform, SmokeNetworkExpansion, SmokeNetworkAbstractions
• Selected Performance tags: @PerformanceAccountList
• Risk Level: high
• AI Confidence: 80%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are concentrated in Multichain Account UI components and Identity backup/sync toggles:

• MultichainAccountSelectorList (AccountListCell, ExternalAccountCell) directly affects account selection and multi-account management flows → impacts SmokeAccounts.
• SmartAccountModal and SmartAccountNetworkList affect smart/multichain account details and per-network handling → impacts multi-chain provider behavior and account switching flows → SmokeNetworkExpansion and SmokeNetworkAbstractions.
• BackupAndSyncToggle and BackupAndSyncFeaturesToggles directly affect account sync and backup settings → impacts SmokeIdentity. Per tag rules, when touching account sync or multi-SRP flows, also select SmokeAccounts and SmokeWalletPlatform.
• Multichain account architecture and account hierarchy presentation affect core wallet platform behavior (multi-SRP, account switching, provider events) → SmokeWalletPlatform.

These components are central to account selection, sync, and multi-chain handling, which are high-risk shared surfaces used across many E2E flows (navigation, dApp connections, transactions). Therefore, a high risk level is appropriate.

No direct changes to confirmations, swaps, perps, predictions, ramps, card, or snaps were observed, and no controller/Engine-level logic was modified.

Performance Test Selection:
Changes to AccountListCell and ExternalAccountCell directly affect account list rendering and account selector behavior. This can impact rendering performance, especially in multi-account scenarios. Therefore, Account List performance tests should run. No evidence of onboarding, launch, swap, or asset-loading performance impact.

View GitHub Actions results

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
11 value mismatches detected (expected — fixture represents an existing user).
View details

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud