feat: hide Speed up and Cancel when gas is paid with alternate token#27404
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Key changes:
Tag selection reasoning:
Tags NOT selected:
Risk level: Medium - The change is a targeted UI behavior fix (hiding buttons for a specific transaction type), well-tested with unit tests, but affects core transaction display components used across the app. Performance Test Selection: |
The committed fixture schema is out of date. To update, comment: |
|



Description
Hides the Speed up and Cancel actions in the activity list and in transaction details when the user has chosen a non‑native token to pay for gas (
selectedGasFeeToken), because those flows are not supported for gas‑fee‑token transactions.Changelog
CHANGELOG entry: Added check to hide Speed up and Cancel buttons in the activity list and transaction details when the user has selected another token to pay for gas
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/2424
Manual testing steps
Screenshots/Recordings
gasless.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI-logic change that only gates rendering of existing actions based on
selectedGasFeeToken, with unit tests added to prevent regressions.Overview
Hides Speed up and Cancel actions for pending/approved transactions when
selectedGasFeeTokenis set (i.e., gas is paid with a non-native token) in both the activity list (TransactionElement) and the transaction details sheet (TransactionDetails).Adds a shared utility
hasGasFeeTokenSelectedinconfirmations/utils/transactionand extends test coverage to assert the buttons are suppressed when a gas fee token is selected (and still shown otherwise).Written by Cursor Bugbot for commit c323793. This will update automatically on new commits. Configure here.