Skip to content

fix(wallet): remove account menu feature flag#27593

Closed
cursor[bot] wants to merge 5 commits into
mainfrom
cursor/jira-auto-fix-processing-b45c
Closed

fix(wallet): remove account menu feature flag#27593
cursor[bot] wants to merge 5 commits into
mainfrom
cursor/jira-auto-fix-processing-b45c

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor Bot commented Mar 18, 2026

Description

Removes the mobileUxAccountMenu remote feature flag and makes the account menu permanently enabled in mobile. This eliminates runtime gating for the hamburger/account-menu experience and prevents future remote flag toggles from changing behavior.

Changelog

CHANGELOG entry: Removed the hamburger menu feature flag and permanently enabled the account menu.

Related issues

Fixes:
Refs: TMCU-456

Manual testing steps

Feature: Account menu is always enabled

  Scenario: Open account menu from settings navigation
    Given the wallet is unlocked on the main home view
    When I tap the Settings tab in bottom navigation
    Then the Accounts Menu view is displayed

  Scenario: Open account menu from wallet header
    Given the wallet is unlocked on the main home view
    When I tap the hamburger menu button in the wallet header
    Then the Accounts Menu view is displayed

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web View Automation 

Note

Medium Risk
Removes runtime gating for the Settings/Account Menu entry points and changes Wallet header actions (QR scanner/notifications), which can impact core navigation and user access paths. Main risk is regressions in navigation stack behavior and missing/relocated actions across platforms.

Overview
Makes the Account Menu permanently enabled by removing the mobileUxAccountMenu remote flag, its selector/hook, and its registry entry.

Updates navigation so the Settings tab and SettingsFlow always start at Routes.ACCOUNTS_MENU_VIEW, and removes conditional Settings-page entries that were previously hidden/shown based on the flag (snapshots/tests updated accordingly).

Simplifies Wallet header actions by removing the QR-scan entry point and routing notifications access through the hamburger/account menu, with e2e/page-object tests updated to navigate via AccountMenu.

Written by Cursor Bugbot for commit 4bce482. This will update automatically on new commits. Configure here.

@github-actions github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk size-M labels Mar 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added risk-high Extensive testing required · High bug introduction risk size-XL and removed risk-medium Moderate testing recommended · Possible bug introduction risk risk-high Extensive testing required · High bug introduction risk size-M labels Mar 19, 2026
@PatrykLucka PatrykLucka force-pushed the cursor/jira-auto-fix-processing-b45c branch from 17c9835 to e96de0d Compare March 20, 2026 11:52
@PatrykLucka PatrykLucka force-pushed the cursor/jira-auto-fix-processing-b45c branch from e96de0d to 4bce482 Compare March 23, 2026 09:22
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@PatrykLucka PatrykLucka marked this pull request as ready for review March 23, 2026 11:41
@PatrykLucka PatrykLucka requested review from a team as code owners March 23, 2026 11:41
Copy link
Copy Markdown
Contributor Author

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

expect(
await findByTestId(`route-${Routes.QR_TAB_SWITCHER}`),
).toBeOnTheScreen();
expect(queryByTestId(WalletViewSelectorsIDs.WALLET_SCAN_BUTTON)).toBeNull();
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View test is a render-only scenario with no interaction

Low Severity

The test 'scan button is not rendered when account menu is enabled' is a pure render scenario — it only calls queryByTestId and asserts absence with toBeNull(). It has no fireEvent, waitFor/findBy, store.dispatch/act, or Engine spy. The component view test rules (Golden Rule #7 and the Self-Review Checklist item #1) explicitly prohibit render-only scenarios: "every test must have at least one of: fireEvent, waitFor/findBy, store.dispatch/act, or an Engine spy. Static visibility checks are not tests."

Fix in Cursor Fix in Web

Triggered by project rule: Component View Test Agent

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

external-contributor risk-high Extensive testing required · High bug introduction risk size-XL team-mobile-ux Mobile UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants