fix(wallet): remove account menu feature flag#27593
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
17c9835 to
e96de0d
Compare
Co-authored-by: Patryk Łucka <PatrykLucka@users.noreply.github.com>
…y based on account menu settings
…vigation assertions
e96de0d to
4bce482
Compare
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
|
|
✅ E2E Fixture Validation — Schema is up to date |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| expect( | ||
| await findByTestId(`route-${Routes.QR_TAB_SWITCHER}`), | ||
| ).toBeOnTheScreen(); | ||
| expect(queryByTestId(WalletViewSelectorsIDs.WALLET_SCAN_BUTTON)).toBeNull(); |
There was a problem hiding this comment.
View test is a render-only scenario with no interaction
Low Severity
The test 'scan button is not rendered when account menu is enabled' is a pure render scenario — it only calls queryByTestId and asserts absence with toBeNull(). It has no fireEvent, waitFor/findBy, store.dispatch/act, or Engine spy. The component view test rules (Golden Rule #7 and the Self-Review Checklist item #1) explicitly prohibit render-only scenarios: "every test must have at least one of: fireEvent, waitFor/findBy, store.dispatch/act, or an Engine spy. Static visibility checks are not tests."
Triggered by project rule: Component View Test Agent





Description
Removes the
mobileUxAccountMenuremote feature flag and makes the account menu permanently enabled in mobile. This eliminates runtime gating for the hamburger/account-menu experience and prevents future remote flag toggles from changing behavior.Changelog
CHANGELOG entry: Removed the hamburger menu feature flag and permanently enabled the account menu.
Related issues
Fixes:
Refs: TMCU-456
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Removes runtime gating for the Settings/Account Menu entry points and changes Wallet header actions (QR scanner/notifications), which can impact core navigation and user access paths. Main risk is regressions in navigation stack behavior and missing/relocated actions across platforms.
Overview
Makes the Account Menu permanently enabled by removing the
mobileUxAccountMenuremote flag, its selector/hook, and its registry entry.Updates navigation so the Settings tab and
SettingsFlowalways start atRoutes.ACCOUNTS_MENU_VIEW, and removes conditional Settings-page entries that were previously hidden/shown based on the flag (snapshots/tests updated accordingly).Simplifies Wallet header actions by removing the QR-scan entry point and routing notifications access through the hamburger/account menu, with e2e/page-object tests updated to navigate via
AccountMenu.Written by Cursor Bugbot for commit 4bce482. This will update automatically on new commits. Configure here.