test: Migrate page objects to the new framework (perf/Predict)

[cortisiko]

Description

Migrates several E2E page objects (Predict flows and TransactionPayConfirmation) from Detox-only elements/gestures to the new unified encapsulated element model with UnifiedGestures, adding Appium/Playwright locators and framework-conditional actions via encapsulatedAction.

Extends selectors by introducing PredictBalanceSelectorsText.AVAILABLE_BALANCE (sourced from enContent) and updates Predict market list/details interactions to use category-label mapping, outcome-button ancestor/XPath matching, and additional visibility/assertion helpers. Also adds a TabBarComponent.tapBrowser() helper and tightens tapWallet() validation to assert WalletView.totalBalance visibility.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Moderate risk because it refactors E2E test page objects and gesture plumbing to a new cross-framework abstraction; failures will surface as flaky/broken tests across Detox/Appium rather than runtime app issues.

Overview
Migrates several E2E page objects (Predict market list/details and TransactionPayConfirmation) from Detox-only elements/gestures to the unified encapsulated element model, adding Appium/Playwright locators and using UnifiedGestures plus encapsulatedAction where Detox-specific delays/scrolling are needed.

Extends Predict selectors with PredictBalanceSelectorsText.AVAILABLE_BALANCE and updates Predict interactions to use category label mapping, ancestor/XPath outcome targeting, and new visibility/assertion helpers (e.g., tab content checks, volume label).

Enhances the gesture abstraction by allowing UnifiedGestureOptions to pass Detox-only scrollToElement parameters (direction, scrollAmount), and adds a TabBarComponent.tapBrowser() convenience method.

^{Written by Cursor Bugbot for commit cb77792. This will update automatically on new commits. Configure here.}

[cursor]

New visibility assertions incompatible with Appium framework context

Medium Severity

Several newly added methods (waitForScreenToDisplay, isAboutTabContentDisplayed, isOutcomesTabContentDisplayed, verifyVolumeTextDisplayed, hasOutcomesTab, isAmountEntryVisible, isPayWithTokenListVisible, verifyTransactionFeeVisible) pass EncapsulatedElementType directly to the Detox-only Assertions.expectElementToBeVisible. In Appium context, the element resolves to a PlaywrightElement, but Assertions internally calls Detox globals like device.getPlatform() and waitFor, which will crash. Unlike expectText or tapOpenPosition, these methods lack encapsulatedAction dispatch.

Additional Locations (1)

• tests/page-objects/Confirmation/TransactionPayConfirmation.ts#L196-L201

 

[cortisiko]

valid point Cursor. I opened a task where we can handle this in a separate PR

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.33%. Comparing base (bb5bfa8) to head (0415dda).
⚠️ Report is 74 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #27642      +/-   ##
==========================================
+ Coverage   82.19%   82.33%   +0.14%     
==========================================
  Files        4788     4785       -3     
  Lines      123512   123611      +99     
  Branches    27364    27507     +143     
==========================================
+ Hits       101516   101777     +261     
+ Misses      14962    14788     -174     
- Partials     7034     7046      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[github-actions]

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud