Skip to content

Release/test runway rc ios workflow#27650

Closed
weitingsun wants to merge 29 commits into
mainfrom
release/test-runway-rc-ios-workflow
Closed

Release/test runway rc ios workflow#27650
weitingsun wants to merge 29 commits into
mainfrom
release/test-runway-rc-ios-workflow

Conversation

@weitingsun
Copy link
Copy Markdown
Contributor

@weitingsun weitingsun commented Mar 18, 2026

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

High Risk
Adds new GitHub Actions release-candidate workflows that can trigger OTA updates, build artifacts, and upload to TestFlight, so misconfiguration could block or incorrectly ship release automation. The ios/fastlane/Fastfile currently contains unresolved merge-conflict markers around TestFlight group handling, which is a build-breaking CI risk.

Overview
Introduces new Runway RC GitHub Actions workflows for iOS and Android that decide between triggering an OTA update (based on OTA_VERSION changes) or running the standard build.yml pipeline; the iOS workflow additionally uploads the built IPA to TestFlight and posts a run summary.

Updates build.yml input handling so ref can be used as the base branch/checkout target when source_branch is not provided, and bumps mobile build numbers (versionCode/CURRENT_PROJECT_VERSION/Bitrise VERSION_NUMBER) to 4127.

Adjusts TestFlight upload documentation/scripts to support "upload-only" mode via TESTFLIGHT_DISTRIBUTE_EXTERNAL=false, but the Fastlane lane change includes merge-conflict markers that must be resolved before it can run.

Written by Cursor Bugbot for commit a63ef54. This will update automatically on new commits. Configure here.

@weitingsun weitingsun requested a review from a team as a code owner March 18, 2026 20:46
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Mar 18, 2026
Comment thread .github/workflows/runway_ios_rc_workflow.yml
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 18, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 18, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 18, 2026
Comment thread .github/workflows/runway_ios_rc_workflow.yml Outdated
Comment thread .github/workflows/runway_ios_rc_workflow.yml
fix permission issue

test ota update

[skip ci] Bump version number to 4061

resolve if release tag does not exist

fix no PR number found error

fix base branch issue

change version to 7.69.0

change to workflow_dispatch

revert build number

change ota version

revert build number
@weitingsun weitingsun requested a review from a team as a code owner March 19, 2026 23:02
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 19, 2026
Comment thread .github/workflows/runway_ios_rc_workflow.yml
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 19, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 19, 2026
@weitingsun weitingsun requested a review from a team as a code owner March 20, 2026 16:22
@weitingsun weitingsun force-pushed the release/test-runway-rc-ios-workflow branch from 98770a5 to 45bfe83 Compare March 20, 2026 17:22
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
All 11 changed files are exclusively CI/CD infrastructure, build configuration, and documentation — with zero app source code changes:

  1. build.yml — Minor logic fix for base-branch/checkout_ref_for_setup to consider inputs.ref when inputs.source_branch is empty. Pure CI workflow change.
  2. runway_android_rc_workflow.yml — New GitHub Actions workflow for Runway-triggered Android RC builds (OTA vs full build decision). CI infrastructure only.
  3. runway_ios_rc_workflow.yml — New GitHub Actions workflow for Runway-triggered iOS RC builds with TestFlight upload. CI infrastructure only.
  4. tests/framework/fixtures/README.md — Whitespace-only change (trailing space trimmed). Pure documentation.
  5. android/app/build.gradle — Version code bump: 3607 → 4110. Build metadata only, no functional change.
  6. ios/MetaMask.xcodeproj/project.pbxproj — CURRENT_PROJECT_VERSION bump: 3911 → 4110 across all build configurations. Build metadata only.
  7. bitrise.yml — VERSION_NUMBER and FLASK_VERSION_NUMBER bumps: 3911 → 4110. CI config only.
  8. ios/fastlane/Fastfile — Refactored upload_to_testflight to conditionally include groups only when distribute_external is true. TestFlight upload script change, not app code.
  9. scripts/upload-to-testflight.sh — Added documentation comment for TESTFLIGHT_DISTRIBUTE_EXTERNAL env var. No functional change.
  10. .agents/skills/e2e-test/SKILL.md — Internal skill documentation update.
  11. ios/fastlane/README.md — Documentation only.

None of these changes affect the app's runtime behavior, user-facing features, navigation, controllers, or any component that E2E tests exercise. Running Detox E2E tests would provide no validation value for these purely CI/build/documentation changes.

Performance Test Selection:
No app source code changes were made. All changes are CI/CD workflows, build configuration (version code bumps), and documentation. Performance tests measure app runtime behavior and are not relevant here.

View GitHub Actions results

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread ios/fastlane/Fastfile
<<<<<<< HEAD
=======
groups: groups,
>>>>>>> wsun/create-runway-rc-ios-workflow
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unresolved git merge conflict markers in Fastfile

High Severity

Git merge conflict markers (<<<<<<< HEAD, =======, >>>>>>> wsun/create-runway-rc-ios-workflow) were accidentally committed into ios/fastlane/Fastfile. Ruby cannot parse these markers, so any Fastlane lane execution — including the new Runway iOS RC TestFlight upload — will fail with a syntax error. This breaks all TestFlight upload workflows that rely on this file.

Fix in Cursor Fix in Web

@sonarqubecloud
Copy link
Copy Markdown

@weitingsun weitingsun closed this Mar 20, 2026
@weitingsun weitingsun deleted the release/test-runway-rc-ios-workflow branch March 20, 2026 23:32
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk-low Low testing needed · Low bug introduction risk size-M team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants