-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: upgrade design-system-react-native to 0.11.0 and deprecate replaced components #27652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ed75eb1
8f6c82f
9bb18de
c33add8
5987809
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -153,6 +153,9 @@ exports[`Login renders matching snapshot 1`] = ` | |
| "letterSpacing": 0, | ||
| "lineHeight": 24, | ||
| }, | ||
| { | ||
| "lineHeight": 0, | ||
| }, | ||
|
Comment on lines
+156
to
+158
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lineHeight fix for MMDS components MetaMask/metamask-design-system#960 Curiously the BeforeVersion before the bug fix is also fine. before720.movAfterVersion after the bug fix is the same after.password.mov |
||
| { | ||
| "textAlignVertical": "center", | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,7 +83,7 @@ const ManualBackupStep1 = () => { | |
| ); | ||
|
|
||
| const [seedPhraseHidden, setSeedPhraseHidden] = useState(true); | ||
| const [password, setPassword] = useState<string | undefined>(undefined); | ||
| const [password, setPassword] = useState(''); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Input controlled-value change from MetaMask/metamask-design-system#960 made this field require a string empty state. Using "" here keeps TextField controlled and avoids the undefined value type breakage. AfterNo visual changes and input still works as expected after720.mov |
||
| const [warningIncorrectPassword, setWarningIncorrectPassword] = useState< | ||
| string | undefined | ||
| >(undefined); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -269,7 +269,7 @@ | |
|
|
||
| const renderWarning = () => ( | ||
| <Box testID={RevealSeedViewSelectorsIDs.SEED_PHRASE_WARNING_ID}> | ||
| <Banner | ||
|
Check warning on line 272 in app/components/Views/RevealPrivateCredential/RevealPrivateCredential.tsx
|
||
| variant={BannerVariant.Alert} | ||
| severity={BannerAlertSeverity.Error} | ||
| title={ | ||
|
|
@@ -335,6 +335,7 @@ | |
| ) : ( | ||
| <Box twClassName="p-5 pb-0"> | ||
| <PasswordEntry | ||
| password={password} | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update due to controlled input only change from design system library update |
||
| onPasswordChange={setPassword} | ||
| onSubmit={tryUnlock} | ||
| warningMessage={warningIncorrectPassword} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,6 +49,7 @@ export interface SeedPhraseConcealerProps { | |
| } | ||
|
|
||
| export interface PasswordEntryProps { | ||
| password: string; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updating |
||
| onPasswordChange: (password: string) => void; | ||
| onSubmit: () => void; | ||
| warningMessage: string; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating breaking change
isFloatinghas changed tovariant={ButtonIconVariant.Floating}