Skip to content

feat(agents): add skill authoring standard#27733

Merged
bfullam merged 4 commits into
mainfrom
skill-creation-skill
Mar 24, 2026
Merged

feat(agents): add skill authoring standard#27733
bfullam merged 4 commits into
mainfrom
skill-creation-skill

Conversation

@bfullam
Copy link
Copy Markdown
Contributor

@bfullam bfullam commented Mar 20, 2026

Description

Adds a canonical repo-local skill authoring standard directly in .agents/skills/repo-skill-authoring/SKILL.md so agents can create and update MetaMask Mobile repo-local skills with a minimal file set.

This PR introduces the repo-skill-authoring skill as the canonical artifact in .agents/skills/, keeps a thin Claude skill shim that points directly to it, and removes the redundant docs SSOT, Cursor command shim, Claude command shim, and per-skill AGENTS.md entry.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk documentation/config-only change that adds new agent skill guidance without impacting runtime app code.

Overview
Adds a new canonical repo-local agent skill, repo-skill-authoring, defining the standard structure, naming rules, and authoring workflow for skills under .agents/skills/.

Registers the skill for the OpenAI/Codex harness via agents/openai.yaml and adds a minimal Claude shim in .claude/skills/ that points back to the canonical .agents SKILL.md.

Written by Cursor Bugbot for commit 4cc1eb1. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Mar 20, 2026
@github-actions github-actions Bot added size-M risk-low Low testing needed · Low bug introduction risk labels Mar 20, 2026
@bfullam bfullam changed the title Add skill-authoring standard and entrypoints feat(agents): add skill authoring standard Mar 20, 2026
@bfullam bfullam enabled auto-merge March 20, 2026 13:04
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 20, 2026
Copy link
Copy Markdown
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the full file set, my main concern is the signal-to-noise ratio: 6 files added, 5 of which are one-liner pointers to the single docs/repo-skill-authoring.md that holds the actual content.

A leaner approach:

  • Put content directly in .agents/skills/repo-skill-authoring/SKILL.md — Cursor and Codex already discover skills from there. No need for a separate docs/ file.
  • Auto-generate .claude/skills/ and .claude/commands/ shims via a yarn claude:generate:skills script that scans .agents/skills/*/SKILL.md and emits pointers. .gitignore the generated files so they don't pollute the repo.
  • Drop .cursor/commands/create-repo-skill.md — Cursor discovers skills from .agents/skills/, not from .cursor/commands/.
  • Drop the per-skill AGENTS.md section — skill discovery is already automated by each harness. AGENTS.md is useful for things that aren't auto-discovered (setup, architecture, conventions).

This brings the per-skill cost down from 6 hand-maintained files to 2 (SKILL.md + openai.yaml), with Claude shims derived automatically.

The authoring standard itself is valuable — I'd just inline it into the skill's SKILL.md rather than giving it its own SSOT + pointer chain.

Comment thread .cursor/commands/create-repo-skill.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.cursor/commands/create-repo-skill.md is a double indirection

The Cursor command shim references the Claude command, which itself references the docs SSOT. That's two hops to reach the actual content: Cursor command → Claude command → docs/repo-skill-authoring.md. Every other shim goes directly to the docs. This one should too for consistency.

Comment thread AGENTS.md
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skill discovery is already automated by each harness — Cursor reads available_skills, Claude scans .claude/skills/, Codex scans .agents/skills/. No agent reads AGENTS.md to find skills.

AGENTS.md is useful for things that aren't auto-discovered: project setup commands, architecture overview, testing conventions, directory structure. Adding per-skill entries to it is redundant with the discovery mechanism and creates one more place to keep in sync.

So in my proposed structure, AGENTS.md stays as-is — no per-skill section added.

Comment thread .claude/skills/repo-skill-authoring/SKILL.md
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 24, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 99%
click to see 🤖 AI reasoning details

E2E Test Selection:
All 3 changed files are purely AI agent skill documentation and configuration files located in .agents/skills/repo-skill-authoring/ and .claude/skills/repo-skill-authoring/. These files define how AI agents should author repo-local skills and contain no application code, test infrastructure, UI components, controllers, navigation, or any other code that could affect the MetaMask Mobile app behavior. There is zero impact on any E2E test flows, and no performance-sensitive code was modified.

Performance Test Selection:
No application code, UI components, controllers, or performance-sensitive code was modified. All changes are purely AI agent skill documentation files with no impact on app performance.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@bfullam bfullam added this pull request to the merge queue Mar 24, 2026
@NicolasMassart NicolasMassart added the area-devex Issues and PRs focused on developer experience label Mar 24, 2026
Merged via the queue into main with commit fcdbf7e Mar 24, 2026
71 checks passed
@bfullam bfullam deleted the skill-creation-skill branch March 24, 2026 18:10
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 24, 2026
@metamaskbot metamaskbot added the release-7.72.0 Issue or pull request that will be included in release 7.72.0 label Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-devex Issues and PRs focused on developer experience release-7.72.0 Issue or pull request that will be included in release 7.72.0 risk-low Low testing needed · Low bug introduction risk size-M team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants