chore: create an checkbox to upload the sourcemap in build mobile workflow#27750
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27750 +/- ##
==========================================
+ Coverage 82.34% 82.42% +0.07%
==========================================
Files 4787 4802 +15
Lines 123646 123906 +260
Branches 27511 27594 +83
==========================================
+ Hits 101822 102126 +304
+ Misses 14779 14713 -66
- Partials 7045 7067 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ask/metamask-mobile into wsun/upload-sourcemap-in-GHA-build
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| targetSdkVersion rootProject.ext.targetSdkVersion | ||
| versionName "7.72.0" | ||
| versionCode 3607 | ||
| versionName "7.71.0" |
There was a problem hiding this comment.
Android versionName downgraded from 7.72.0 to 7.71.0
High Severity
The Android versionName was changed from "7.72.0" to "7.71.0", which is a version downgrade. This is inconsistent with every other version reference in the project: iOS MARKETING_VERSION is 7.72.0, bitrise.yml VERSION_NAME is 7.72.0, and FLASK_VERSION_NAME is 7.72.0. This mismatch likely causes the Android build to ship with the wrong marketing version.
| cat ios/.xcode.env.local | ||
| node --version | ||
|
|
||
| # Sentry: build.sh defaults SENTRY_DISABLE_AUTO_UPLOAD=true; set false only when opted in. |
There was a problem hiding this comment.
Instead of this couldn't we just add the environment variable in builds.yml?
I see that we only set this for rc and production builds to false in build.sh
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
None of these changes affect: app source code, UI components, controllers, navigation, test page objects, test fixtures, or any user-facing functionality. No E2E tests are needed to validate these changes. Performance Test Selection: |
|





Description
Add an optional job to upload sourcemap to Sentry
Sentry: https://metamask.sentry.io/settings/projects/metamask-mobile/source-maps/?query=4123
Changelog
CHANGELOG entry: Added a checkbox to upload sourcemap on build mobile workflow
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches the mobile build/release pipeline and version numbering across Android/iOS/Bitrise, which can affect artifact reproducibility and release ordering if misconfigured. The Sentry upload toggle is opt-in but relies on correct environment auth and build scripts honoring
SENTRY_DISABLE_AUTO_UPLOAD.Overview
Adds a new
upload_to_sentryinput to the GitHub Actionsbuild.ymlworkflow and wires it to aConfigure Sentry uploadstep that togglesSENTRY_DISABLE_AUTO_UPLOADfor the subsequent platform build.Updates build/version numbers used by the native projects and CI (
android/app/build.gradle,ios/MetaMask.xcodeproj/project.pbxproj, andbitrise.yml) to align on4138(and adjusts AndroidversionName).Written by Cursor Bugbot for commit 0230a9c. This will update automatically on new commits. Configure here.