fix(ramp): fixes order details bug cp-7.71.0

[georgeweiler]

Description

Fixes an order details UI bug where the title for bank transfer details was displaying for non bank-transfer orders.

TRAM 3359

Changelog

CHANGELOG entry: fixes an order details UI bug

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

*

*Before**

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Low risk UI-only change that gates rendering of the bank details section; main risk is unintentionally hiding bank details if upstream field names/structure change.

Overview
Fixes an order details UI bug where the bank-transfer section header could render for non-bank-transfer orders.

OrderContent now returns null for bankDetailFields unless at least one expected bank detail field (e.g., amount, routing/account, IBAN/BIC) is present, and tests add coverage for absent/empty/non-matching paymentDetails vs. bank-transfer/SEPA scenarios.

^{Written by Cursor Bugbot for commit 65f6cfc. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeRamps
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 95%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are isolated to two files in the Ramp/OrderDetails feature area:

1. OrderContent.tsx: A small, targeted bug fix that adds an early return (if (!hasAnyField) return null) when no bank transfer payment detail fields are present. This prevents rendering an empty "To complete your order" bank details section when paymentDetails has no relevant fields (e.g., for credit/debit card orders that don't require bank transfer info).

2. OrderContent.test.tsx: Adds unit tests covering the new behavior — verifying the section doesn't render when paymentDetails is absent or has no matching fields, and verifying it renders correctly for US bank transfer (routing/account number) and SEPA (IBAN/BIC) scenarios. Also fixes a minor comment typo (→ to ->).

Impact assessment:

• Change is entirely within the Ramp feature's OrderDetails view
• No shared components (TabBar, navigation, modals, confirmations) are affected
• No controller or Engine changes
• No performance implications
• The fix is low-risk: it only adds a guard clause to prevent rendering empty UI sections

Tag selection: SmokeRamps is the appropriate tag as it covers fiat on-ramp/off-ramp features including order details flows. No dependent tags are required per the SmokeRamps description (it only mentions SmokeWalletPlatform when wallet home/actions entry points are changed, which is not the case here).

Performance Test Selection:
The change is a simple conditional rendering guard in the OrderContent component. It adds an early return when no bank transfer fields are present, which is a negligible performance improvement (avoids rendering an empty section). No performance-sensitive code paths, data loading, state management, or UI rendering performance is meaningfully impacted.

View GitHub Actions results

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
18 value mismatches detected (expected — fixture represents an existing user).
View details

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud