fix(perps): validate TP/SL prices, clear stale config, and block invalid orders cp-7.71.0

[michalconsensys]

Description

Fixes three related bugs in the Perps order form involving Take Profit (TP) and Stop Loss (SL) prices that were restored from a previous session's pending trade configuration:

1. Stale TP/SL persisted after order submission: The pendingTradeConfiguration was not cleared after a successful order, causing previously set TP/SL values to reappear on the next order form visit — even auto-submitting a stop loss the user never intended.

2. TP/SL displayed as "off" despite being set: When the RoE calculation clamped to zero (e.g., the TP/SL price was on the wrong side of the current market price), the "Auto close" summary row showed "off" instead of the actual price. The TP/SL edit form, however, showed the correct value — a confusing inconsistency.

3. No validation or blocking for invalid TP/SL direction: A restored TP/SL price that ended up on the wrong side of the market (e.g., take profit below entry for a long) was silently accepted and could be submitted, leading to immediate execution or unexpected behavior.

Changes

• Call clearPendingTradeConfiguration after successful order execution to prevent stale TP/SL restoration.
• Display the formatted price in the "Auto close" row when RoE rounds to zero, instead of showing "off".
• Validate TP/SL prices against current market price and trade direction using existing isValidTakeProfitPrice / isValidStopLossPrice utilities.
• Show inline error warnings when TP or SL is on the wrong side of the current price.
• Disable the "Place order" button while TP/SL is invalid.

Changelog

CHANGELOG entry: Fixed a bug where stale Take Profit and Stop Loss prices could persist across orders and display incorrectly in the Perps order form

Related issues

Fixes: #27793

Manual testing steps

Feature: Perps order TP/SL validation

  Scenario: stale TP/SL is cleared after placing an order
    Given the user has a Perps position open with TP and SL set
    And the user navigates to the order form

    When the user places the order successfully
    And the user returns to the order form for the same asset
    Then the TP and SL fields should be empty (not restored from previous order)

  Scenario: TP/SL on the wrong side shows warning and blocks submission
    Given the user is on the Perps order form for a Long position
    And the user sets a Take Profit price below the current market price

    When the order form validates the TP price
    Then a warning is displayed: "Take profit must be above current price. Update or clear it to place the order."
    And the "Place order" button is disabled

  Scenario: TP/SL on the wrong side for Short position
    Given the user is on the Perps order form for a Short position
    And the user sets a Stop Loss price below the current market price

    When the order form validates the SL price
    Then a warning is displayed: "Stop loss must be above current price. Update or clear it to place the order."
    And the "Place order" button is disabled

  Scenario: TP/SL with zero RoE displays price instead of "off"
    Given the user is on the Perps order form with a TP or SL set
    And the TP/SL price results in an RoE that rounds to 0%

    When the "Auto close" summary row renders
    Then it displays the formatted price value instead of "off"

Screenshots/Recordings

N/A — validation logic and text changes only; no layout or visual design changes.

Before

N/A

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Changes the Perps order submission/validation path to block orders when TP/SL is on the wrong side and clears stored pending trade config after submission, which could affect order placement behavior. Risk is mitigated by added unit coverage for market vs limit reference price and button-disabled states.

Overview
Prevents Perps orders from being submitted with invalid TP/SL trigger prices by validating TP/SL against the appropriate reference price (current for market orders, entry/limit for limit orders), showing inline warnings, and disabling the Place order button when TP/SL is wrong-side.

Fixes TP/SL display inconsistencies by showing the formatted TP/SL price in the summary row when computed RoE clamps to 0% instead of rendering off, and clears PerpsController.clearPendingTradeConfiguration(asset) after successful submission to avoid restoring stale TP/SL on subsequent visits.

Adds new i18n strings for the wrong-side TP/SL warnings and expands PerpsOrderView tests to cover wrong-side validation, limit-order reference pricing, and the monochrome A/B button variant disablement.

^{Written by Cursor Bugbot for commit 7c10dc8. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Pending config cleared even when order execution fails

Medium Severity

clearPendingTradeConfiguration runs unconditionally after executeOrder, but executeOrder (from usePerpsOrderExecution) never throws — it catches all errors internally and resolves regardless of success or failure. This means the pending trade config (including TP/SL) is cleared even when the order fails on the exchange, contradicting the comment's stated intent of clearing only "after successful submission." If a user's order fails, their TP/SL settings are lost when they return to the order form.

 

[michalconsensys]

This is intended

[geositta]

I added a suggestion regarding the bugbot finding. Please add a test that fails on current code and passes after the fix, proving limit order TP/SL is validated against entry price when entry and market prices differ.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokePerps, SmokeWalletPlatform, SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 90%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are scoped to the Perps order view (PerpsOrderView.tsx) with the following modifications:

1. TP/SL wrong-side price validation: New logic using isValidTakeProfitPrice and isValidStopLossPrice to validate that take profit and stop loss prices are on the correct side of the current/entry price. For limit orders, validation uses the limit price as reference instead of market price.

2. Button disable logic: The Place Order button is now disabled when hasInvalidTPSL is true, preventing order submission with invalid TP/SL prices.

3. Warning messages: New UI warnings displayed when TP/SL prices are on the wrong side, using new localization strings added to en.json.

4. Post-order cleanup: After successful order submission, Engine.context.PerpsController?.clearPendingTradeConfiguration is called to prevent stale TP/SL values from being restored.

5. TP/SL display fix: When RoE is 0, shows formatted price instead of "off".

Tag selection rationale:

• SmokePerps: Directly tests Perps functionality including the Add Funds flow and order placement, which is the core area changed.
• SmokeWalletPlatform: Required by SmokePerps tag description since Perps is a section inside the Trending tab.
• SmokeConfirmations: Required by SmokePerps tag description since Add Funds deposits are on-chain transactions.

The changes are contained within the Perps feature area with no impact on shared navigation, modals, or other wallet components. The localization changes are Perps-specific strings only.

Performance Test Selection:
The changes are UI validation logic additions (warning display, button disable state) within the Perps order view. There are no changes to rendering performance, data loading, state management at scale, or any components that would affect app startup, account/network list rendering, or other performance-sensitive areas. No performance tests are warranted.

View GitHub Actions results

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
18 value mismatches detected (expected — fixture represents an existing user).
View details

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[geositta]

Thanks for adding that limit order validation - looks good from my end.