refactor(wallet): remove account menu feature flag

[PatrykLucka]

Description

Removes the mobileUxAccountMenu remote feature flag and makes the account menu permanently enabled in mobile. This eliminates runtime gating for the hamburger/account-menu experience and prevents future remote flag toggles from changing behavior.

Changelog

CHANGELOG entry: Removed the hamburger menu feature flag and permanently enabled the account menu.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TMCU-456

Manual testing steps

Feature: Account menu is always enabled

  Scenario: Open account menu from settings navigation
    Given the wallet is unlocked on the main home view
    When I tap the Settings tab in bottom navigation
    Then the Accounts Menu view is displayed

  Scenario: Open account menu from wallet header
    Given the wallet is unlocked on the main home view
    When I tap the hamburger menu button in the wallet header
    Then the Accounts Menu view is displayed

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Changes navigation and UI entry points around Settings/Accounts Menu, which can break deep links, back stacks, and tests if any flows still expect the legacy Settings root or removed buttons.

Overview
Makes the Accounts Menu permanently enabled by removing the mobileUxAccountMenu remote feature flag (including its selectors/tests and registry entry) and deleting related flag-constant wiring.

Updates navigation so the bottom Settings tab and SettingsFlow always start at Routes.ACCOUNTS_MENU_VIEW, and trims the legacy Settings and SecuritySettings screens by removing entries/sections now considered part of the Accounts Menu (e.g., SDK connections, contacts/permissions/about/support/request feature/lock).

Adjusts wallet header behavior and extensive E2E/test coverage to use the Accounts Menu as the new entry point for actions like notifications, contacts, and locking the app.

^{Written by Cursor Bugbot for commit 8077076. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[georgewrmarshall]

LGTM! Approving changes on behalf of @MetaMask/design-system-engineers

[baptiste-marchand]

LGTM on notifications files

[gantunesr]

Approved for accounts

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeIdentity, SmokeWalletPlatform, FlaskBuildTests, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeMultiChainAPI, SmokeConfirmations, SmokeTrade
• Selected Performance tags: None (no tests recommended)
• Risk Level: high
• AI Confidence: 90%

click to see 🤖 AI reasoning details

E2E Test Selection:
This PR removes the mobileUxAccountMenu feature flag and makes the Account Menu (hamburger menu) the permanent, always-on navigation path for Settings. This is a significant navigation infrastructure change affecting virtually every test that:

1. Navigates to Settings
2. Locks the wallet
3. Accesses contacts, notifications, or other settings items

Core changes:

• useAccountMenuEnabled hook and selectAccountMenuEnabled selector deleted
• TabBar.tsx now always navigates to Routes.ACCOUNTS_MENU_VIEW (no conditional)
• MainNavigator.js SettingsFlow now always starts at Routes.ACCOUNTS_MENU_VIEW
• TabBarComponent.tapSettings() now goes through tapAccountsMenu() first, then AccountMenu.tapSettings()
• Settings view items (contacts, permissions, about, lock, support) removed from old conditional paths
• Wallet view QR scanner and notification bell removed from old conditional paths
• AccountMenu page object gains notificationsButton and tapNotifications()

Directly modified test files:

• tests/regression/accounts/change-account-name*.spec.ts → SmokeAccounts
• tests/regression/accounts/change-password.spec.ts → SmokeAccounts
• tests/smoke/identity/account-syncing/account-syncing-settings-toggle.spec.ts → SmokeIdentity
• tests/smoke/identity/contact-syncing/contact-sync-toggle.spec.ts → SmokeIdentity
• tests/smoke/identity/contact-syncing/sync-users-contacts.spec.ts → SmokeIdentity
• tests/smoke/notifications/enable-notifications-after-onboarding.spec.ts → SmokeNetworkAbstractions
• tests/smoke/snaps/test-snap-management.spec.ts → FlaskBuildTests
• tests/smoke/wallet/settings/delete-wallet.spec.ts → SmokeWalletPlatform
• tests/smoke/wallet/settings/addressbook-*.spec.ts → SmokeWalletPlatform
• tests/smoke/account-activity/web-socket-connection.spec.ts → SmokeWalletPlatform
• tests/smoke/seedless/utils.ts → affects seedless flows
• tests/regression/multichain/permissions/accounts/permission-system-delete-wallet.failing.ts → SmokeNetworkExpansion/SmokeMultiChainAPI

Broad impact via TabBarComponent.tapSettings() change:

• tapSettings() now routes through AccountMenu first — any test using this method is affected
• This includes: SmokeAccounts (reveal SRP, auto-lock, AES tests), SmokeTrade (swap prep), SmokeConfirmations (via swap prep), SmokeNetworkAbstractions (notification settings), SmokeNetworkExpansion (multichain permissions)

Tag dependencies per descriptions:

• SmokeIdentity → also select SmokeAccounts and SmokeWalletPlatform
• SmokeNetworkExpansion → also select SmokeConfirmations
• SmokeMultiChainAPI → also select SmokeNetworkAbstractions and SmokeNetworkExpansion
• SmokeTrade → also select SmokeConfirmations

The navigation change is fundamental and cross-cutting — the hamburger menu is now the permanent entry point to all settings flows, affecting nearly every test suite that touches settings, locking, or account management.

Performance Test Selection:
The changes are primarily navigation/routing refactoring (removing a feature flag and making AccountMenu the permanent navigation path). While TabBar.tsx is modified, the changes are structural/conditional logic removal rather than performance-impacting rendering changes. No new components are added, no list rendering changes, no data loading changes, and no state management changes that would affect performance metrics.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

[gantunesr]

Approved for accounts CO files

[christopherferreira9]

looks good for qa