Skip to content

chore: adds market insights metric to Perps view entry point cp-7.71.0#27814

Merged
zone-live merged 3 commits into
mainfrom
TSA-market-insights-perps-metric
Mar 23, 2026
Merged

chore: adds market insights metric to Perps view entry point cp-7.71.0#27814
zone-live merged 3 commits into
mainfrom
TSA-market-insights-perps-metric

Conversation

@zone-live
Copy link
Copy Markdown
Contributor

@zone-live zone-live commented Mar 23, 2026

Description

Adds two missing metric events to the Perps Market Details view to bring it to parity with the token details flow. MARKET_INSIGHTS_OPENED now fires whenever a user taps the Market Insights entry card, and PERPS_SCREEN_VIEWED now includes a market_insights_displayed boolean property that reflects whether a report was actually shown, with the event held until the insights fetch resolves so the value is fully accurate.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: changes are limited to analytics instrumentation and event timing gated on Market Insights loading, with added unit tests to validate tracking and navigation behavior.

Overview
Adds missing Market Insights instrumentation to the Perps market details screen.

PerpsMarketDetailsView now fires MetaMetricsEvents.MARKET_INSIGHTS_OPENED (with perps_market) when the Market Insights entry card is tapped, and delays MetaMetricsEvents.PERPS_SCREEN_VIEWED until insights loading completes so it can include an accurate market_insights_displayed boolean.

Updates/extends PerpsMarketDetailsView.test.tsx with mocks for useMarketInsights/feature flags and new tests covering the new tracking payloads and navigation to Routes.MARKET_INSIGHTS.VIEW with isPerps: true.

Written by Cursor Bugbot for commit dc97116. This will update automatically on new commits. Configure here.

@zone-live zone-live requested a review from a team as a code owner March 23, 2026 14:57
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-social-ai Social & AI team label Mar 23, 2026
@github-actions github-actions Bot added size-M risk-low Low testing needed · Low bug introduction risk labels Mar 23, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 23, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps, SmokeWalletPlatform, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are scoped to PerpsMarketDetailsView.tsx and its test file. The modifications are:

  1. Extracting isLoading from useMarketInsights to delay the PERPS_SCREEN_VIEWED analytics event until market insights finish loading — ensuring market_insights_displayed reflects actual state rather than a loading-time snapshot.
  2. Adding market_insights_displayed property to the PERPS_SCREEN_VIEWED analytics event.
  3. Adding MARKET_INSIGHTS_OPENED analytics tracking when the market insights entry card is pressed.
  4. Adding track to the dependency array of handleMarketInsightsPress.

These are analytics/tracking improvements with no UI changes. The component is only imported by the Perps routes (index.ts and routes/index.tsx), so impact is contained.

SmokePerps is selected as the primary tag since this is a Perps screen. SmokeWalletPlatform is required per tag description (Perps is a section inside Trending tab). SmokeConfirmations is required per SmokePerps tag description (Add Funds deposits are on-chain transactions).

Performance Test Selection:
The changes are purely analytics tracking improvements — adding event properties and ensuring events fire after loading completes. There are no UI rendering changes, no list rendering modifications, no state management changes, and no changes to data loading patterns. No performance impact is expected.

View GitHub Actions results

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud
Copy link
Copy Markdown

@zone-live zone-live changed the title chore: adds market insights metric to Perps view entry point chore: adds market insights metric to Perps view entry point cp-7.71.0 Mar 23, 2026
@zone-live zone-live added this pull request to the merge queue Mar 23, 2026
Merged via the queue into main with commit 6e0f698 Mar 23, 2026
182 of 184 checks passed
@zone-live zone-live deleted the TSA-market-insights-perps-metric branch March 23, 2026 16:45
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 23, 2026
@metamaskbot metamaskbot added the release-7.72.0 Issue or pull request that will be included in release 7.72.0 label Mar 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.72.0 Issue or pull request that will be included in release 7.72.0 risk-low Low testing needed · Low bug introduction risk size-M team-social-ai Social & AI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants