chore: add commas to PnL

[juanmigdr]

Description

Add commas to PnL

Changelog

CHANGELOG entry: add commas to PnL

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2966

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Low risk UI-only change to how the price difference (PnL) value is formatted and signed in AssetOverview.

Overview
Improves the AssetOverview price-diff (PnL) label formatting by switching from addCurrencySymbol(diff, ...) to formatPriceWithSubscriptNotation(Math.abs(diff), ...), which adds thousands separators and consistent small-value formatting.

Also fixes sign rendering so negative diffs show a leading - (positive keeps +, zero shows no sign) while keeping the percentage calculation display unchanged.

^{Written by Cursor Bugbot for commit 4055c10. This will update automatically on new commits. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: None (no tests recommended)
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 85%

click to see 🤖 AI reasoning details

E2E Test Selection:
The change is a small, isolated UI fix in app/components/UI/AssetOverview/Price/Price.tsx:

1. What changed:

   • Added explicit - sign for negative price differences (previously only + was shown for positive)
   • Uses formatPriceWithSubscriptNotation for non-zero diffs to better display very small numbers
   • Minor spacing/formatting adjustments

2. Scope: This component is used only in TokenDetails/components/AssetOverviewContent.tsx (the token detail/asset overview screen). It's a purely cosmetic display fix.

3. No E2E test coverage found: Searching through the entire test suite found no E2E tests that specifically test the price diff display in the asset overview. No test files reference AssetOverview, TokenOverview, AssetDetails, or priceDiff in the E2E test directories.

4. No shared component impact: The change doesn't affect navigation, modals, confirmations, controllers, or any shared infrastructure that could break other tests.

5. Risk: Low - isolated UI rendering fix with no side effects on state management, navigation, or other components.

Since no E2E tags cover this specific UI component's price display functionality, and the change is a low-risk cosmetic fix, no E2E tags need to be run.

Performance Test Selection:
The change is a minor UI rendering fix for price difference display formatting. It doesn't affect list rendering performance, data loading, state management, or any critical user flows that would impact measurable performance metrics. No performance tests are warranted.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud