Skip to content

chore(runway): cherry-pick chore: adds market insights metric to Perps view entry point cp-7.71.0#27821

Merged
chloeYue merged 1 commit into
release/7.71.0from
runway-cherry-pick-7.71.0-1774284390
Mar 24, 2026
Merged

chore(runway): cherry-pick chore: adds market insights metric to Perps view entry point cp-7.71.0#27821
chloeYue merged 1 commit into
release/7.71.0from
runway-cherry-pick-7.71.0-1774284390

Conversation

@runway-github
Copy link
Copy Markdown
Contributor

@runway-github runway-github Bot commented Mar 23, 2026

Description

Adds two missing metric events to the Perps Market Details view to bring
it to parity with the token details flow. MARKET_INSIGHTS_OPENED now
fires whenever a user taps the Market Insights entry card, and
PERPS_SCREEN_VIEWED now includes a market_insights_displayed boolean
property that reflects whether a report was actually shown, with the
event held until the insights fetch resolves so the value is fully
accurate.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Low risk: changes are limited to analytics instrumentation and event
timing gated on Market Insights loading, with added unit tests to
validate tracking and navigation behavior.

Overview
Adds missing Market Insights instrumentation to the Perps market
details screen.

PerpsMarketDetailsView now fires
MetaMetricsEvents.MARKET_INSIGHTS_OPENED (with perps_market) when
the Market Insights entry card is tapped, and delays
MetaMetricsEvents.PERPS_SCREEN_VIEWED until insights loading completes
so it can include an accurate market_insights_displayed boolean.

Updates/extends PerpsMarketDetailsView.test.tsx with mocks for
useMarketInsights/feature flags and new tests covering the new
tracking payloads and navigation to Routes.MARKET_INSIGHTS.VIEW with
isPerps: true.

Written by Cursor
Bugbot
for commit
dc97116. This will update automatically
on new commits. Configure
here.

[6e0f698](https://github.com/MetaMask/metamask-mobile/commit/6e0f698a7fc6d58c005e7c86f05f1288dfeb2607)

…s view entry point cp-7.71.0 (#27814)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Adds two missing metric events to the Perps Market Details view to bring
it to parity with the token details flow. `MARKET_INSIGHTS_OPENED` now
fires whenever a user taps the Market Insights entry card, and
`PERPS_SCREEN_VIEWED` now includes a `market_insights_displayed` boolean
property that reflects whether a report was actually shown, with the
event held until the insights fetch resolves so the value is fully
accurate.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk: changes are limited to analytics instrumentation and event
timing gated on Market Insights loading, with added unit tests to
validate tracking and navigation behavior.
> 
> **Overview**
> Adds missing Market Insights instrumentation to the Perps market
details screen.
> 
> `PerpsMarketDetailsView` now fires
`MetaMetricsEvents.MARKET_INSIGHTS_OPENED` (with `perps_market`) when
the Market Insights entry card is tapped, and delays
`MetaMetricsEvents.PERPS_SCREEN_VIEWED` until insights loading completes
so it can include an accurate `market_insights_displayed` boolean.
> 
> Updates/extends `PerpsMarketDetailsView.test.tsx` with mocks for
`useMarketInsights`/feature flags and new tests covering the new
tracking payloads and navigation to `Routes.MARKET_INSIGHTS.VIEW` with
`isPerps: true`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
dc97116. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner March 23, 2026 16:46
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Mar 23, 2026
@github-actions github-actions Bot added size-M risk-low Low testing needed · Low bug introduction risk labels Mar 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps, SmokeWalletPlatform, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are scoped entirely to PerpsMarketDetailsView.tsx and its test file. The modifications are:

  1. Extracting isLoading from useMarketInsights to delay the PERPS_SCREEN_VIEWED analytics event until market insights finish loading (ensuring accurate market_insights_displayed property)
  2. Adding market_insights_displayed property to the PERPS_SCREEN_VIEWED event
  3. Adding MARKET_INSIGHTS_OPENED analytics tracking when the market insights entry card is pressed
  4. Fixing the useCallback dependency array to include track

These are analytics/tracking improvements with no changes to core navigation, shared components, or business logic. The component is only imported by the Perps routes.

Tag selection rationale:

  • SmokePerps: Direct change to PerpsMarketDetailsView, a core Perps view
  • SmokeWalletPlatform: Per SmokePerps description, changes to Perps views affect the Trending section in SmokeWalletPlatform
  • SmokeConfirmations: Required by SmokePerps description (Add Funds deposits are on-chain transactions)

Performance Test Selection:
The changes are limited to analytics event tracking (adding a new event property and a new event call). There are no changes to rendering logic, list components, data fetching patterns, state management, or any performance-sensitive code paths. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

Copy link
Copy Markdown
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chloeYue chloeYue merged commit 5ee4f82 into release/7.71.0 Mar 24, 2026
97 checks passed
@chloeYue chloeYue deleted the runway-cherry-pick-7.71.0-1774284390 branch March 24, 2026 08:17
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk-low Low testing needed · Low bug introduction risk size-M team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants