-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: implement wallet-side analytics for SDKConnectV2 / MWP #27864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
86faa00
feat: implement wallet-side analytics for SDKConnectV2 / MWP
ffmcgee725 5af23b6
fix: fully apply analytics consent gate
ffmcgee725 a714499
address jiexi feedback
ffmcgee725 5648f95
Merge branch 'main' into jc/WAPI-1348
ffmcgee725 f732379
test: increase test coverage
ffmcgee725 9515c47
minor change
ffmcgee725 5e5d57c
Merge branch 'main' into jc/WAPI-1348
ffmcgee725 f7cfbfe
refactor: remove unecessary async behaviour from synchronous function
ffmcgee725 69da9df
Merge branch 'main' into jc/WAPI-1348
ffmcgee725 96efa49
Merge branch 'main' into jc/WAPI-1348
ffmcgee725 67cfeb6
Revert "minor change"
ffmcgee725 661cd13
Revert "refactor: remove unecessary async behaviour from synchronous …
ffmcgee725 ee26b03
test: coverage for trackWalletEvent function call
ffmcgee725 649399a
Merge branch 'main' into jc/WAPI-1348
adonesky1 d438073
refactor: remove redundant wallet_connection_user_approved/rejected e…
adonesky1 e085d8e
refactor: remove redundant wallet_connection_user_approved/rejected V…
ffmcgee725 1c6e53c
refactor: align MWP event names and properties with Segment schema
adonesky1 f8c5383
Merge branch 'main' into jc/WAPI-1348
ffmcgee725 265b384
refactor: use the proper MetaMetrics flow rather than the out of band…
ffmcgee725 b34e59d
Merge branch 'main' into jc/WAPI-1348
ffmcgee725 11068f9
fix: make sure analytics calls are not blocking mwp flows
ffmcgee725 da0cf7f
fix: make sure failure event tracking is not lost
ffmcgee725 984ed41
Merge branch 'main' into jc/WAPI-1348
ffmcgee725 9627dd0
Merge branch 'main' into jc/WAPI-1348
ffmcgee725 4ac6ac5
add transport type to mwp calls and fix remote_session_id
ffmcgee725 10dfdff
Merge branch 'main' into jc/WAPI-1348
ffmcgee725 891879c
refactor: use constant for mwp ref
ffmcgee725 fecd54c
fix: add missing signature property to MWP Deep Link Used event
adonesky1 373f7d4
fix: remove unplanned platform property from MWP analytics events
adonesky1 30c4875
remove unecessary mocks
ffmcgee725 1c96b2b
Merge branch 'main' into jc/WAPI-1348
ffmcgee725 8b86d4a
Merge branch 'main' into jc/WAPI-1348
ffmcgee725 41d7707
Merge branch 'main' into jc/WAPI-1348
ffmcgee725 0e612b5
fix: resolve duplicate REMOTE_CONNECTION_REQUEST_RECEIVED after main …
adonesky1 efb7b89
refactor: remove dead parameter from function trackMwpDeepLinkUsed
ffmcgee725 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test name combines multiple behaviors with "and"
Low Severity
The test name
'routes MWP deeplinks to SDKConnectV2 and bypasses the standard flow'uses "and" to combine two distinct behaviors (routing to SDKConnectV2, and bypassing the standard saga flow) into a single test description. Per the unit testing guidelines, test names must not combine multiple logical conditions with AND/OR. The test should be split into two separate, focused test cases.Triggered by project rule: Unit Testing Guidelines
Reviewed by Cursor Bugbot for commit 1c6e53c. Configure here.