Skip to content

chore: enable batched account creation for Solana#28429

Merged
gantunesr merged 1 commit intomainfrom
feat/solana-batched-account-creation
Apr 9, 2026
Merged

chore: enable batched account creation for Solana#28429
gantunesr merged 1 commit intomainfrom
feat/solana-batched-account-creation

Conversation

@gantunesr
Copy link
Copy Markdown
Member

@gantunesr gantunesr commented Apr 6, 2026

Description

Bumps @metamask/solana-wallet-snap from ^2.7.4 to ^2.8.0 and enables batch account creation for the Solana provider.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1651

Manual testing steps

Feature: Solana batched account creation

  Scenario: user imports a power user SRP with multiple Solana accounts
    Given Backup & Sync is enabled
    And the user imports a new power user SRP

    When account discovery completes
    Then all multichain Solana accounts are correctly created

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor


Note

Medium Risk
Changes multichain account creation behavior for the Solana provider (now batched), which could affect account discovery/creation flows; other providers remain unchanged. Also bumps the Solana snap dependency, introducing potential upstream behavior changes.

Overview
Enables batched account creation for Solana by passing a Solana-specific provider config (createAccounts.batched: true) into MultichainAccountService initialization, while keeping BTC/TRX configs non-batched.

Adds unit coverage asserting the per-provider batched flag, and bumps @metamask/solana-wallet-snap from ^2.7.4 to ^2.8.0 (lockfile updated accordingly).

Reviewed by Cursor Bugbot for commit b04c4ac. Bugbot is set up for automated code reviews on this repo. Configure here.

…or Solana

Bumps `@metamask/solana-wallet-snap` from `^2.7.4` to `^2.8.0` and enables
`batched: true` in the Solana provider's `createAccounts` config so that
`MultichainAccountService` can create multiple Solana accounts in a single
request. BTC and TRX providers retain `batched: false`. Updates the
corresponding unit tests to assert the batched flag per provider.

Made-with: Cursor
@gantunesr gantunesr self-assigned this Apr 6, 2026
@metamaskbot metamaskbot added the team-accounts-framework Accounts team label Apr 6, 2026
@github-actions github-actions bot added the size-S label Apr 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@gantunesr gantunesr changed the title bump(@metamask/solana-wallet-snap): enable batched account creation for Solana chore: enable batched account creation for Solana Apr 6, 2026
@gantunesr gantunesr marked this pull request as ready for review April 6, 2026 20:53
@gantunesr gantunesr requested a review from a team as a code owner April 6, 2026 20:53
@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 6, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​solana-wallet-snap@​2.7.4 ⏵ 2.8.089 -110088 +197 +4100

View full report

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 6, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • npm/@metamask/solana-wallet-snap@2.8.0

View full report

@gantunesr
Copy link
Copy Markdown
Member Author

@SocketSecurity ignore @metamask/solana-wallet-snap

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 6, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

@gantunesr
Copy link
Copy Markdown
Member Author

https://github.com/SocketSecurity ignore @metamask/solana-wallet-snap@2.8.0

@gantunesr
Copy link
Copy Markdown
Member Author

This is manually tested but I'm not adding the recordings since it exposes several seed phrases

@ccharly
Copy link
Copy Markdown
Contributor

ccharly commented Apr 9, 2026

@SocketSecurity ignore npm/@metamask/solana-wallet-snap@2.8.0

This is our Snap.

@gantunesr gantunesr added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit d732206 Apr 9, 2026
221 of 229 checks passed
@gantunesr gantunesr deleted the feat/solana-batched-account-creation branch April 9, 2026 13:32
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2026
@metamaskbot metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.74.0 Issue or pull request that will be included in release 7.74.0 size-S team-accounts-framework Accounts team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants