release: 7.78.21 (OTA)

.claude/commands/unit-test.md

@@ -5,20 +5,18 @@
 ## Steps
 
 1. **Get changed files**
-
    - Run `git diff --name-only --diff-filter=ACMR` for all changes (staged + unstaged)
    - Filter for `.js`, `.jsx`, `.ts`, `.tsx` files
    - Display list
 
 2. **Find test files**
-
    - Check if file is already a test file (contains `.test.`)
    - For source files, find related tests: `{basename}.test.{ext}`
    - Exclude snapshots (`.snap`)
    - Collect unique test files
+   - **Flag any `toMatchSnapshot()` calls found** — these are banned; note them for migration to explicit assertions or `toMatchInlineSnapshot()`
 
 3. **Run tests**
-
    - Execute `yarn jest` with all found test files
    - Run without coverage
    - Capture results

.cursor/rules/unit-testing-guidelines.mdc

@@ -173,6 +173,62 @@ testID={`token-item-${token.symbol}`}
 testID={`network-option-${network.chainId}`}
 ```
 
+## Snapshot Testing Policy - MANDATORY
+
+### The Rule
+
+- ❌ **`toMatchSnapshot()` is BANNED** — Do not use it. Do not add it. Do not approve it.
+- ✅ **`toMatchInlineSnapshot()` is ALLOWED** — Use sparingly, only when the serialized output is the meaningful assertion.
+
+### Why `toMatchSnapshot()` Is Banned
+
+External snapshot files (`.snap`) have three critical problems:
+
+1. **Invisible in review** — The diff lives in a separate `.snap` file that reviewers routinely rubber-stamp. Regressions hide there.
+2. **No code ownership** — `CODEOWNERS` explicitly assigns `**/*.snap` to *nobody*, meaning no team is accountable for snapshot correctness.
+3. **Brittle by design** — Any style tweak, whitespace change, or unrelated refactor regenerates the snapshot and silently passes CI.
+
+### Why `toMatchInlineSnapshot()` Is Allowed
+
+The snapshot string lives directly in the test file, so:
+- It appears in the PR diff alongside the code that produces it
+- The file's code owner is responsible for reviewing it
+- Reviewers can see exactly what changed and why
+
+### When to Use `toMatchInlineSnapshot()`
+
+Only use it when the serialized shape of the output **is** the assertion — for example, verifying a complex object structure, a formatted string, or a serialized data payload. Do **not** use it as a lazy substitute for explicit `expect` calls.
+
+```ts
+// ❌ BANNED — writes to an external .snap file
+expect(tree).toMatchSnapshot();
+expect(component).toMatchSnapshot();
+expect(result).toMatchSnapshot();
+
+// ✅ ALLOWED — snapshot is inline and visible in review
+expect(result).toMatchInlineSnapshot(`
+  {
+    "chainId": "0x1",
+    "name": "Ethereum Mainnet",
+  }
+`);
+
+// ✅ PREFERRED — explicit assertions are always better than snapshots
+expect(result.chainId).toBe('0x1');
+expect(result.name).toBe('Ethereum Mainnet');
+```
+
+### Migrating Existing `toMatchSnapshot()` Calls
+
+When you encounter an existing `toMatchSnapshot()` call:
+1. **Prefer replacing it** with explicit `expect` assertions targeting the specific values that matter.
+2. If the full serialized output is genuinely meaningful, convert to `toMatchInlineSnapshot()`.
+3. Delete the corresponding `.snap` file entry once migrated.
+
+Do **not** leave `toMatchSnapshot()` in place when modifying a test file — migrate it as part of your change.
+
+---
+
 ## Assertions - PREFER toBeOnTheScreen
 
 - **ALWAYS use `toBeOnTheScreen()`** to assert element presence - NOT `toBeTruthy()` or `toBeDefined()`
@@ -398,7 +454,7 @@ it.each(['small', 'medium', 'large'] as const)('renders %s size', (size) => {
 ## Test Determinism
 
 - **EVERYTHING** not under test must be mocked - no exceptions.
-- Avoid brittle tests: do not test internal state or UI snapshots for logic.
+- Avoid brittle tests: do not test internal state or UI snapshots for logic. **`toMatchSnapshot()` is banned** — see Snapshot Testing Policy above.
 - Only test public behavior, not implementation details.
 - Mock time, randomness, and external systems to ensure consistent results.
 
@@ -514,7 +570,7 @@ expect(result).toBe(false);
 ```
 
 - Ensure tests use proper matchers (`toBeOnTheScreen` vs `toBeDefined`).
-- Do not approve PRs without reviewing snapshot diffs, it can reveal errors.
+- **Reject any new `.snap` files or new `toMatchSnapshot()` calls** — these are banned; require the author to use explicit assertions or `toMatchInlineSnapshot()` instead.
 - Reject tests with complex names combining multiple logical conditions (AND/OR).
 
 # Refactoring Support
@@ -527,6 +583,7 @@ expect(result).toBe(false);
 
 Before submitting any test file, verify:
 
+- [ ] **No `toMatchSnapshot()` calls** — BANNED; use explicit assertions or `toMatchInlineSnapshot()` instead
 - [ ] **No mocking to inject testIDs** - Use component's built-in testID support
 - [ ] **testIDs via child prop objects** - Use `closeButtonProps={{ testID }}` not mocks
 - [ ] **No "should" in any test name**
@@ -545,6 +602,7 @@ Before submitting any test file, verify:
 
 # Common Mistakes to AVOID - CRITICAL
 
+- ❌ **Using `toMatchSnapshot()`** — BANNED; it writes opaque `.snap` files with no code owner; use explicit assertions or `toMatchInlineSnapshot()` instead
 - ❌ **Mocking to inject testIDs** - Components already support testID (see guidelines above)
 - ❌ **Using "should" in test names** - This is the #1 mistake, use action-oriented descriptions
 - ❌ **Testing multiple behaviors in one test** - One test, one behavior
@@ -588,8 +646,9 @@ yarn test:unit:coverage
 ## Workflow Requirements
 
 - Confirm all tests are passing before commit.
-- When a snapshot update is detected, confirm the changes are expected.
-- Do not blindly update snapshots without understanding the differences.
+- **Do not add new `toMatchSnapshot()` calls** — this is banned. See Snapshot Testing Policy.
+- When modifying a test file that contains `toMatchSnapshot()`, opportunistically migrate those calls to explicit assertions or `toMatchInlineSnapshot()` — do not block a PR solely to force migration, but do not add new ones.
+- `toMatchInlineSnapshot()` updates are acceptable but must be reviewed — confirm the new inline snapshot reflects an intentional, expected change.
 
 # Reference Code Examples
 
@@ -606,12 +665,14 @@ it('indicates expired milk when past due date', () => {
 });
 ```
 
-## ❌ Brittle Snapshot
+## ❌ Banned: `toMatchSnapshot()`
 
 ```ts
+// ❌ BANNED — toMatchSnapshot() writes to an external .snap file.
+// It has no code owner, hides regressions, and breaks on trivial changes.
 it('renders the button', () => {
   const { container } = render(<MyButton />);
-  expect(container).toMatchSnapshot(); // 🚫 fails on minor style changes
+  expect(container).toMatchSnapshot(); // 🚫 BANNED — do not use
 });
 ```
 
@@ -640,7 +701,7 @@ it('hides selector when disabled', () => {
 
 ## Reviewer Responsibilities
 
-Validate tests fail when code breaks • Ensure proper matchers • Review snapshot diffs • Reject complex names with AND/OR
+Validate tests fail when code breaks • Ensure proper matchers • **Reject new `toMatchSnapshot()` calls and new `.snap` files** • Reject complex names with AND/OR
 
 ```ts
 // OK
@@ -652,6 +713,6 @@ it('renders and disables button when input is empty or missing required field');
 
 ## Workflow
 
-Always run tests after changes • Confirm all pass before commit • Review snapshot changes • Don't blindly update snapshots
+Always run tests after changes • Confirm all pass before commit • **Do not add new `toMatchSnapshot()` calls** — migrate existing ones to explicit assertions or `toMatchInlineSnapshot()` when touching a test file
 
 **Resources**: [Contributor docs](https://github.com/MetaMask/contributor-docs/blob/main/docs/testing/unit-testing.md) • [Jest Matchers](https://jestjs.io/docs/using-matchers) • [React Native Testing Library](https://testing-library.com/docs/react-native-testing-library/intro/)

.detoxrc.js

@@ -82,7 +82,7 @@ module.exports = {
     'ios.simulator': {
       type: 'ios.simulator',
       device: {
-        type: 'iPhone 15 Pro',
+        type: 'iPhone 16 Pro',
       },
     },
     'android.emulator': {

.eslintrc.js

@@ -167,81 +167,10 @@ module.exports = {
         'no-console': 'off',
       },
     },
-    {
-      // Temporary rollout strategy:
-      // Keep color-no-hex disabled for all tests by default, then re-enable it
-      // for specific folders in small PR batches. Once migration is complete,
-      // remove this override and enforce across all tests in:
-      // - app/components/
-      // - app/component-library/
-      files: ['**/*.test.{js,ts,tsx}', '**/*.stories.{js,ts,tsx}'],
-      rules: {
-        '@metamask/design-tokens/color-no-hex': 'off',
-      },
-    },
     {
       files: [
-        // @MetaMask/card
-        'app/components/UI/Card/**/*.{js,jsx,ts,tsx}',
-        // @MetaMask/core-platform
-        'app/components/Snaps/**/*.{js,jsx,ts,tsx}',
-        // @MetaMask/predict
-        'app/components/UI/Predict/**/*.{js,jsx,ts,tsx}',
-        // @MetaMask/ramp
-        'app/components/UI/Ramp/**/*.{js,jsx,ts,tsx}',
-        // @MetaMask/rewards
-        'app/components/UI/Rewards/**/*.{js,jsx,ts,tsx}',
-        // @MetaMask/perps
-        'app/components/UI/Perps/**/*.{js,jsx,ts,tsx}',
-        // @MetaMask/metamask-earn
-        'app/components/UI/Earn/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/Stake/**/*.{js,jsx,ts,tsx}',
-        // @MetaMask/metamask-assets
-        'app/components/UI/Assets/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/Tokens/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/AssetOverview/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/Collectibles/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/CollectibleContractElement/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/CollectibleContractInformation/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/CollectibleContractOverview/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/CollectibleContracts/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/CollectibleDetectionModal/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/CollectibleMedia/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/CollectibleModal/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/CollectibleOverview/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/ConfirmAddAsset/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/DeFiPositions/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/TokenDetails/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/AddAsset/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/Asset/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/AssetDetails/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/AssetHideConfirmation/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/AssetOptions/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/Collectible/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/CollectibleView/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/DetectedTokens/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/NFTAutoDetectionModal/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/NftDetails/**/*.{js,jsx,ts,tsx}',
-        // @MetaMask/mobile-core-ux
-        'app/components/Views/AccountActions/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/AccountSelector/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/AccountsMenu/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/AddressQRCode/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/EditAccountName/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/LockScreen/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/Login/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/MultichainTransactionsView/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/NetworkConnect/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/NetworkSelector/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/QRAccountDisplay/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/QRScanner/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/Settings/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/TermsAndConditions/**/*.{js,jsx,ts,tsx}',
-        'app/components/Views/UnifiedTransactionsView/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/MultichainTransactionListItem/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/TransactionActionModal/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/TransactionElement/**/*.{js,jsx,ts,tsx}',
-        'app/components/UI/Transactions/**/*.{js,jsx,ts,tsx}',
+        'app/components/**/*.{js,jsx,ts,tsx}',
+        'app/component-library/**/*.{js,jsx,ts,tsx}',
       ],
       rules: {
         '@metamask/design-tokens/color-no-hex': 'error',
@@ -331,7 +260,10 @@ module.exports = {
     //
     // See docs/perps/perps-core-sync.md for the full sync workflow.
     {
-      files: ['app/controllers/perps/**/*.{ts,tsx}'],
+      files: [
+        'app/controllers/perps/**/*.{ts,tsx}',
+        'app/**/*-method-action-types*.ts',
+      ],
       excludedFiles: ['**/*.test.ts', '**/*.test.tsx'],
       rules: {
         // === Existing rule ===
@@ -355,6 +287,22 @@ module.exports = {
             message:
               'Use ES private class fields (#field) instead of TypeScript private keyword.',
           },
+          // Mirror @metamask/eslint-config base rule — prevents `'x' in obj`
+          // type-guards that would land in core as new `no-restricted-syntax`
+          // suppressions. Use `hasProperty()` from `@metamask/utils` instead.
+          {
+            selector: "BinaryExpression[operator='in']",
+            message:
+              'The "in" operator is not allowed. Use `hasProperty()` from `@metamask/utils` instead.',
+          },
+          {
+            selector: 'WithStatement',
+            message: 'With statements are not allowed',
+          },
+          {
+            selector: 'SequenceExpression',
+            message: 'Sequence expressions are not allowed',
+          },
         ],
         'id-denylist': [
           'error',
@@ -674,7 +622,7 @@ module.exports = {
     'react/no-string-refs': 'error',
     'react/no-unused-prop-types': 'error',
     'react/prefer-es6-class': 'error',
-    '@metamask/design-tokens/color-no-hex': 'warn',
+    '@metamask/design-tokens/color-no-hex': 'off',
     radix: 'off',
 
     // These rule modifications are removing changes to our shared ESLint config made after

.github/CODEOWNERS

@@ -46,7 +46,9 @@ app/core/DeeplinkManager                                    @MetaMask/mobile-pla
 scripts/build.sh                                            @MetaMask/mobile-platform
 fingerprint.config.js                                       @MetaMask/mobile-platform
 builds.yml                                                  @MetaMask/mobile-platform
+.github/workflows/create-build-branch.yml                   @MetaMask/mobile-platform
 .github/workflows/push-eas-update.yml                       @MetaMask/mobile-admins
+.github/workflows/build-and-upload-to-testflight.yml        @MetaMask/mobile-admins
 .github/workflows/upload-to-testflight.yml                  @MetaMask/mobile-admins
 scripts/update-expo-channel.js                              @MetaMask/mobile-admins
 certs/certificate.pem                                       @MetaMask/mobile-admins
@@ -59,16 +61,17 @@ scripts/set-secrets-from-config.js                          @MetaMask/mobile-adm
 # Platform & Snaps Code Fencing File
 metro.transform.js @MetaMask/mobile-platform @MetaMask/core-platform
 
-# Ramps Team
-app/components/UI/Ramp/                                @MetaMask/ramp
-app/reducers/fiatOrders/                               @MetaMask/ramp
-app/core/Engine/controllers/ramps-controller           @MetaMask/ramp
-app/core/Engine/messengers/ramps-controller-messenger  @MetaMask/ramp
-app/core/Engine/messengers/ramps-service-messenger     @MetaMask/ramp
-app/selectors/rampsController                          @MetaMask/ramp
-**/Ramp/**                                              @MetaMask/ramp
-**/ramp/**                                              @MetaMask/ramp
-**/ramps/**                                             @MetaMask/ramp
+# Money Movement Team (formerly Ramps)
+app/components/UI/Ramp/                                @MetaMask/money-movement
+app/reducers/fiatOrders/                               @MetaMask/money-movement
+app/core/Engine/controllers/ramps-controller           @MetaMask/money-movement
+app/core/Engine/messengers/ramps-controller-messenger  @MetaMask/money-movement
+app/core/Engine/messengers/ramps-service-messenger     @MetaMask/money-movement
+app/selectors/rampsController                          @MetaMask/money-movement
+**/Ramp/**                                              @MetaMask/money-movement
+**/ramp/**                                              @MetaMask/money-movement
+**/ramps/**                                             @MetaMask/money-movement
+**/money-movement/**                                    @MetaMask/money-movement
 
 # Card Team
 app/components/UI/Card/                                    @MetaMask/card
@@ -79,7 +82,7 @@ app/selectors/cardController.ts                            @MetaMask/card
 
 # Confirmation Team
 app/components/Views/confirmations                          @MetaMask/confirmations
-app/components/Views/confirmations/external/staking          @MetaMask/confirmations @MetaMask/metamask-earn
+app/components/Views/confirmations/external/staking          @MetaMask/confirmations @MetaMask/earn
 app/core/Engine/controllers/approval-controller             @MetaMask/confirmations
 app/core/Engine/controllers/gas-fee-controller              @MetaMask/confirmations
 app/core/Engine/controllers/signature-controller            @MetaMask/confirmations
@@ -148,14 +151,14 @@ app/components/UI/TemplateRenderer   @MetaMask/confirmations @MetaMask/core-plat
 
 
 # Earn Team
-app/components/UI/Stake              @MetaMask/metamask-earn
-app/core/Engine/controllers/earn-controller @MetaMask/metamask-earn
-app/core/Engine/messengers/earn-controller-messenger @MetaMask/metamask-earn
-app/selectors/earnController         @MetaMask/metamask-earn
-**/Earn/**                           @MetaMask/metamask-earn
-**/earn/**                           @MetaMask/metamask-earn
-**/Money/**                          @MetaMask/metamask-earn
-**/money/**                          @MetaMask/metamask-earn
+app/components/UI/Stake              @MetaMask/earn
+app/core/Engine/controllers/earn-controller @MetaMask/earn
+app/core/Engine/messengers/earn-controller-messenger @MetaMask/earn
+app/selectors/earnController         @MetaMask/earn
+**/Earn/**                           @MetaMask/earn
+**/earn/**                           @MetaMask/earn
+**/Money/**                          @MetaMask/earn
+**/money/**                          @MetaMask/earn
 
 # Rewards Team
 app/core/Engine/controllers/rewards-controller @MetaMask/rewards
@@ -287,9 +290,9 @@ tests/flows/                                   @MetaMask/qa
 # Note: Test builds (main-test, flask-test) in build/builds.yml are owned by QA team
 # but the file itself is protected by mobile-platform for consistency
 
-# Co-owned by Swaps and Ramps teams
-app/util/parseAmount.ts                      @MetaMask/swaps-engineers @MetaMask/ramp
-app/util/parseAmount.test.ts                 @MetaMask/swaps-engineers @MetaMask/ramp
+# Co-owned by Swaps and Money Movement teams
+app/util/parseAmount.ts                      @MetaMask/swaps-engineers @MetaMask/money-movement
+app/util/parseAmount.test.ts                 @MetaMask/swaps-engineers @MetaMask/money-movement
 
 # Snapshots – no code owners assigned
 # This allows anyone with write access to approve changes to any *.snap files.

.github/actionlint.yaml

@@ -9,8 +9,8 @@ self-hosted-runner:
     - "gha-mm-scale-set-ubuntu-22.04-amd64-small"
     - "gha-mm-scale-set-ubuntu-22.04-amd64-med"
     - "macos-15"
-    - "ghcr.io/cirruslabs/macos-runner:sequoia"
-    - "ghcr.io/cirruslabs/macos-runner:sequoia-xl"
+    - "ghcr.io/cirruslabs/macos-runner:tahoe"
+    - "ghcr.io/cirruslabs/macos-runner:tahoe-xl"
     - "ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-md"
     - "ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-lg"
     - "ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-xl"