chore(rewards): Adjust leaderboard

[sophieqgu]

Description

Unused asset cleanup

• Deleted 8 unused image files from app/images/rewards/ (~5.3 MB total):

Leaderboard crown icons for top 5

• Added a crown icon (crown.svg) next to the referral code for the top 5 entries in OndoLeaderboard
• Crown is only shown in full leaderboard view (hidden in preview mode when maxEntries is specified)

StatCell suffix placement

• Moved the suffix prop (Pending tag, Ineligible tag, check icon) from next to the value to next to the label in StatCell

New reusable LeaderboardPositionHeader component

• Extracted the rank/tier header section (previously duplicated in both views) into a shared component at components/Campaigns/LeaderboardPositionHeader.tsx
• Props: rank, tier, isLoading, isPending, isQualified, isIneligible, showReturn, returnValue, returnColor, showPrizePool, prizePoolValue, prizePoolLoading

Audit en.json

• Removed unused keys
• Checked 'deposit' --> 'inflow', 'withdraw' --> 'outflow'

Audit usage of hooks

• Removed unused useLeaderboard in OndoCampaignStatsView

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Mostly UI refactors, but it changes Ondo leaderboard/stats rendering and adds additional data-fetching (portfolio/deposits) that could affect loading/error states and displayed values.

Overview
Refactors the Ondo campaign rank/tier header UI into a reusable LeaderboardPositionHeader and adopts it in both OndoCampaignStatsView and OndoLeaderboardView, changing how pending/ineligible/qualified indicators are rendered.

Enhances OndoLeaderboard rows by adding a crown icon for the top 5 entries (disabled in preview mode) and tweaks the tier selector icon.

Updates data wiring/tests: OndoLeaderboardView now fetches portfolio + campaign deposits to display return and computed prize pool (via new exported getCurrentPrize/BREAKPOINTS from OndoPrizePool), adjusts StatCell suffix placement, adds component/unit tests, and removes several unused rewards SVG assets and some unused i18n strings.

^{Reviewed by Cursor Bugbot for commit 825897c. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit a87cbdc. Configure here.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: None (no tests recommended)
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 90%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes in this PR are entirely contained within the Rewards feature area (app/components/UI/Rewards/). Specifically:

1. New/modified Rewards UI components: OndoCampaignStatsView, OndoLeaderboardView, OndoLeaderboard, CampaignStatsSummary, LeaderboardPositionHeader, OndoPrizePool - these are all self-contained within the Rewards navigator and don't affect any shared components (TabBar, navigation, modals, confirmations, etc.)

2. Unit test files: OnboardingStep.test.tsx - unit tests only, no E2E impact

3. Image assets: New reward-related images (crown.svg, onboarding images) - static assets with no functional impact

4. Localization cleanup: en.json removes deprecated/unused string keys from the rewards section only - these are cleanup changes for strings that are no longer referenced

No E2E tests exist for the Rewards feature: After thorough investigation of tests/smoke/, there is no rewards, ondo, or campaign test directory. The Rewards feature is not covered by any of the available E2E test tags.

No shared components affected: The changes don't touch TabBar, navigation infrastructure, modals, confirmations, or any other shared components that could break existing E2E tests.

No performance impact: No changes to list rendering, state management, startup code, or other performance-sensitive paths.

Since there are no E2E tests that cover the Rewards feature and the changes are isolated to that feature area without affecting any shared infrastructure, no E2E test tags need to be run.

Performance Test Selection:
The changes are limited to Rewards UI components (leaderboard views, campaign stats, prize pool), image assets, and localization string cleanup. None of these changes affect performance-sensitive code paths such as app startup, account/network list rendering, login flows, swap flows, or asset loading. No performance tests are warranted.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud