fix(rewards): correct text in Ondo after-hours bottom sheet#28935
fix(rewards): correct text in Ondo after-hours bottom sheet#28935Montoya wants to merge 1 commit into
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
These are pure copy/text changes with no logic, navigation, or architectural impact. The changes affect the Perps feature's market hours information display. Per the tag dependency rules:
No performance tests are needed as text/localization changes have no performance impact. Performance Test Selection: |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit be98fd2. Configure here.
| "title": "Market hours", | ||
| "closes_in": "Closes in {{time}}", | ||
| "content": "You're trading within regular market hours (9:30 am to 4 pm EST). When markets are closed, there's risk for wider spreads, price moves, and higher funding rates." | ||
| "content": "You're trading within regular market hours (9:30 am to 4 pm EDT). When markets are closed, some assets may have lower liquidity." |
There was a problem hiding this comment.
EDT hardcoded instead of year-round ET abbreviation
Medium Severity
The timezone abbreviation was changed from EST to EDT, but EDT (Eastern Daylight Time) is only correct from March to November. During winter months, the correct abbreviation is EST. The year-round correct abbreviation for US market hours is ET (Eastern Time), which covers both. Major financial sites like NYSE, Fidelity, and Nasdaq all use ET for this reason.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit be98fd2. Configure here.
| "reopens_in": "Reopens in {{time}}", | ||
| "reopens_in_label": "Reopens in", | ||
| "content": "You're trading outside of regular market hours (9:30 am to 4 pm EST). When markets are closed, there's risk for wider spreads, price moves, and higher funding rates." | ||
| "content": "You're trading outside of regular market hours (9:30 am to 4 pm EDT). When markets are closed, some assets may have lower liquidity." |
There was a problem hiding this comment.
Ondo after-hours text not updated despite PR title
Medium Severity
The PR title says "correct text in Ondo after-hours bottom sheet," but the actual ondo_campaign_after_hours_trading entry (around line 8255) still contains the old EST abbreviation and the old verbose wording. The changes only updated the perps market_hours and after_hours_trading sections, leaving the Ondo-specific section inconsistent and unfixed.
Reviewed by Cursor Bugbot for commit be98fd2. Configure here.


Description
Text used EST instead of EDT and needed to be simplified
Changelog
CHANGELOG entry: null
Related issues
Fixes: n/a
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
String-only localization changes with no logic or data-flow impact; main risk is unintended wording/translation regressions.
Overview
Updates the
en.jsoncopy for the Ondo perps bottom sheet to replace EST with EDT in both Market hours and After-hours trading messages.Simplifies the disclaimer text by removing spread/price/funding-rate risk language and instead noting that when markets are closed, some assets may have lower liquidity.
Reviewed by Cursor Bugbot for commit be98fd2. Bugbot is set up for automated code reviews on this repo. Configure here.