Skip to content

fix(rewards): correct text in Ondo after-hours bottom sheet#28935

Closed
Montoya wants to merge 1 commit into
mainfrom
fix/ondo-afterhours-message
Closed

fix(rewards): correct text in Ondo after-hours bottom sheet#28935
Montoya wants to merge 1 commit into
mainfrom
fix/ondo-afterhours-message

Conversation

@Montoya
Copy link
Copy Markdown
Contributor

@Montoya Montoya commented Apr 16, 2026

Description

Text used EST instead of EDT and needed to be simplified

Changelog

CHANGELOG entry: null

Related issues

Fixes: n/a

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
String-only localization changes with no logic or data-flow impact; main risk is unintended wording/translation regressions.

Overview
Updates the en.json copy for the Ondo perps bottom sheet to replace EST with EDT in both Market hours and After-hours trading messages.

Simplifies the disclaimer text by removing spread/price/funding-rate risk language and instead noting that when markets are closed, some assets may have lower liquidity.

Reviewed by Cursor Bugbot for commit be98fd2. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the risk-low Low testing needed · Low bug introduction risk label Apr 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps, SmokeWalletPlatform, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only change is in locales/languages/en.json, modifying two localization strings for the Perps (perpetuals trading) feature:

  1. perps.market_hours.content: Changed timezone from "EST" to "EDT" and simplified the risk description text
  2. perps.after_hours_trading.content: Same changes

These are pure copy/text changes with no logic, navigation, or architectural impact. The changes affect the Perps feature's market hours information display. Per the tag dependency rules:

  • SmokePerps: Directly tests perpetuals functionality where these strings appear
  • SmokeWalletPlatform: Required by SmokePerps (Perps is a section inside Trending tab)
  • SmokeConfirmations: Required by SmokePerps (Add Funds deposits are on-chain transactions)

No performance tests are needed as text/localization changes have no performance impact.

Performance Test Selection:
Pure localization string changes (timezone abbreviation and description text updates) have no performance impact. No performance tests are needed.

View GitHub Actions results

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit be98fd2. Configure here.

Comment thread locales/languages/en.json
"title": "Market hours",
"closes_in": "Closes in {{time}}",
"content": "You're trading within regular market hours (9:30 am to 4 pm EST). When markets are closed, there's risk for wider spreads, price moves, and higher funding rates."
"content": "You're trading within regular market hours (9:30 am to 4 pm EDT). When markets are closed, some assets may have lower liquidity."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDT hardcoded instead of year-round ET abbreviation

Medium Severity

The timezone abbreviation was changed from EST to EDT, but EDT (Eastern Daylight Time) is only correct from March to November. During winter months, the correct abbreviation is EST. The year-round correct abbreviation for US market hours is ET (Eastern Time), which covers both. Major financial sites like NYSE, Fidelity, and Nasdaq all use ET for this reason.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit be98fd2. Configure here.

Comment thread locales/languages/en.json
"reopens_in": "Reopens in {{time}}",
"reopens_in_label": "Reopens in",
"content": "You're trading outside of regular market hours (9:30 am to 4 pm EST). When markets are closed, there's risk for wider spreads, price moves, and higher funding rates."
"content": "You're trading outside of regular market hours (9:30 am to 4 pm EDT). When markets are closed, some assets may have lower liquidity."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ondo after-hours text not updated despite PR title

Medium Severity

The PR title says "correct text in Ondo after-hours bottom sheet," but the actual ondo_campaign_after_hours_trading entry (around line 8255) still contains the old EST abbreviation and the old verbose wording. The changes only updated the perps market_hours and after_hours_trading sections, leaving the Ondo-specific section inconsistent and unfixed.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit be98fd2. Configure here.

@Montoya Montoya closed this Apr 16, 2026
@Montoya Montoya deleted the fix/ondo-afterhours-message branch April 16, 2026 17:13
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk-low Low testing needed · Low bug introduction risk size-XS team-rewards Rewards team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant