Skip to content

fix(Rewards): Ondo campaign afterhours message#28936

Merged
Montoya merged 1 commit into
mainfrom
fix-ondo-afterhours-sheet
Apr 16, 2026
Merged

fix(Rewards): Ondo campaign afterhours message#28936
Montoya merged 1 commit into
mainfrom
fix-ondo-afterhours-sheet

Conversation

@Montoya
Copy link
Copy Markdown
Contributor

@Montoya Montoya commented Apr 16, 2026

Description

The message was referencing EST instead of EDT and needed changing

Changelog

CHANGELOG entry: null

Related issues

Fixes: n/a

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Text-only localization change in en.json with no impact to logic, data, or security.

Overview
Updates the English locale string for ondo_campaign_after_hours_trading.content to reference EDT (instead of EST) and revises the risk disclaimer wording to emphasize reduced liquidity and higher spreads when markets are closed.

Reviewed by Cursor Bugbot for commit 11d5184. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Montoya Montoya enabled auto-merge April 16, 2026 17:19
@github-actions github-actions Bot added the risk-low Low testing needed · Low bug introduction risk label Apr 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 98%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only changed file is locales/languages/en.json, with a single string update in the ondo_campaign_after_hours_trading section:

  1. Timezone abbreviation changed from "EST" to "EDT"
  2. Minor rewording of the after-hours trading risk description

This is a pure localization/copy change with no code logic, no UI structure changes, no controller modifications, and no impact on any shared components. No E2E tests reference this string directly. The change cannot break any existing test flows. No performance-sensitive code is touched. Running any E2E test tags would be unnecessary overhead for this trivial text correction.

Performance Test Selection:
This is a pure text/localization change with no impact on rendering performance, data loading, state management, or any performance-sensitive code paths. No performance tests are warranted.

View GitHub Actions results

@Montoya Montoya added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 16, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 11d5184. Configure here.

Comment thread locales/languages/en.json
@sonarqubecloud
Copy link
Copy Markdown

@Montoya Montoya added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit 8f8ffa4 Apr 16, 2026
98 checks passed
@Montoya Montoya deleted the fix-ondo-afterhours-sheet branch April 16, 2026 17:56
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.74.0 Issue or pull request that will be included in release 7.74.0 risk-low Low testing needed · Low bug introduction risk size-XS team-rewards Rewards team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants