refactor(ramp): show Ramp settings logout toasts via ToastService#28938
Closed
wachunei wants to merge 1 commit into
Closed
refactor(ramp): show Ramp settings logout toasts via ToastService#28938wachunei wants to merge 1 commit into
wachunei wants to merge 1 commit into
Conversation
Phase 3 toast work for in-scope Ramp Views: replace ToastContext usage in SettingsModal with ToastService (same ref registered by Root’s ToastContextWrapper). Keeps component-library toast option shape for the mounted legacy Toast. Tests mock ToastService instead of ToastContext.
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
|
Member
Author
|
I will close this PR since the current approach is not deprecated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Ramp design-system migration phase 3 (toast) for in-scope
Views:SettingsModalno longer readsToastContextfrom the component library. Logout success and error notifications now callToastService.showToast, which uses the same toast ref registered by Root’sToastContextWrapper(same path asv2OrderToast).Toast payloads still use the legacy component-library
ToastVariantsand icon options because the mounted app toast remains the legacy implementation; this change removes context coupling from the modal and aligns tests withToastServicemocks.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist