Skip to content

refactor(ramp): show Ramp settings logout toasts via ToastService#28938

Closed
wachunei wants to merge 1 commit into
mainfrom
feat/ramp-ds-migration-phase3-toast
Closed

refactor(ramp): show Ramp settings logout toasts via ToastService#28938
wachunei wants to merge 1 commit into
mainfrom
feat/ramp-ds-migration-phase3-toast

Conversation

@wachunei
Copy link
Copy Markdown
Member

Description

Ramp design-system migration phase 3 (toast) for in-scope Views: SettingsModal no longer reads ToastContext from the component library. Logout success and error notifications now call ToastService.showToast, which uses the same toast ref registered by Root’s ToastContextWrapper (same path as v2OrderToast).

Toast payloads still use the legacy component-library ToastVariants and icon options because the mounted app toast remains the legacy implementation; this change removes context coupling from the modal and aligns tests with ToastService mocks.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: Ramp Transak settings — logout toast

  Scenario: Successful logout shows success toast
    Given the user is on the Ramp flow with Transak as provider and is authenticated
    When the user opens Ramp settings and taps Log out
    Then a success toast is shown with the logged-out message

  Scenario: Failed logout shows error toast
    Given the same authenticated Transak context and logout will fail (e.g. forced error in dev)
    When the user taps Log out from Ramp settings
    Then an error toast is shown with the logout error message

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Phase 3 toast work for in-scope Ramp Views: replace ToastContext usage in
SettingsModal with ToastService (same ref registered by Root’s
ToastContextWrapper). Keeps component-library toast option shape for the
mounted legacy Toast. Tests mock ToastService instead of ToastContext.
@wachunei wachunei self-assigned this Apr 16, 2026
@metamaskbotv2 metamaskbotv2 Bot added the team-money-movement issues related to Money Movement features label Apr 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
11 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud
Copy link
Copy Markdown

@wachunei
Copy link
Copy Markdown
Member Author

I will close this PR since the current approach is not deprecated

@wachunei wachunei closed this Apr 16, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-S team-money-movement issues related to Money Movement features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant