chore: fix time range change race condition cp-7.74.0

[sahar-fehri]

Description

Fixes the token advanced chart staying scrolled back in time when users pan and then change the time range quickly. Also avoids sending previous range OHLCV into the WebView while the new fetch is still in flight

Problem
Viewport / scroll — TradingView keeps pan/scroll state inside the WebView. Changing range without a full new surface could reuse that state, so the chart looked wrong after a fast time-range change.

Stale data — useOHLCVChart keeps the last ohlcvData until the new request completes. Right after a range change, props can show the new ohlcvSeriesKey but the old candle array (same reference). Sending that as SET_OHLCV_DATA for the new range causes bad data / races.

Solution
WebView key — Tie key to ohlcvSeriesKey (with ?? '' when the prop is omitted) so each series change remounts the WebView and drops inherited TradingView scroll state.

ohlcvSeriesStaleSnapshotRef + guard — When the series key changes but ohlcvData is still the previous array reference, don’t sync full OHLCV; wait until the hook returns a new array reference, then send.

useEffect on ohlcvSeriesKey — Reset loading / ready state (chartReadyCount, webViewLoaded, layout settle timers) and clear ohlcvSeriesStaleSnapshotRef. Reset activeIndicatorsRef, prevPositionLinesRef, and prevChartTypeRef so the new WebView gets indicators, position lines, and chart type (line vs candles) applied correctly without a default-candles flash.

Changelog

CHANGELOG entry: Fixes race condition on timeRange switch

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

Uploading Screen Recording 2026-04-16 at 23.39.54.mov…

After

Uploading Screen Recording 2026-04-17 at 00.10.19.mov…

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Touches chart lifecycle/sync logic and WebView remount behavior, which could regress loading/skeleton timing or data updates across range switches if edge cases weren’t covered.

Overview
Fixes a race on time-range changes in AdvancedChart by remounting the WebView when ohlcvSeriesKey changes (via a key) and resetting “ready/loading/layout settle” state so the new instance re-applies indicators, position lines, and chart type deterministically.

Adds a stale-series guard (ohlcvSeriesStaleSnapshotRef) that suppresses SET_OHLCV_DATA syncing when the series key updates but ohlcvData is still the previous array reference, resuming only once fresh data arrives; updates tests to reflect the WebView remount/load sequence and stale-data wait behavior.

^{Reviewed by Cursor Bugbot for commit f7a52c7. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sahar-fehri]

When ohlcvSeriesKey changes, the key string changes and react destroys the old WebView and creates a new one.

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
11 value mismatches detected (expected — fixture represents an existing user).
View details

[sahar-fehri]

check to make sure we do not send stale data when ohlcvSeriesKey changes, but should wait for fresh data. If it is stale, it returns and skips sendOHLCVData

[sahar-fehri]

Holds the previous series' ohlcvData array reference after ohlcvSeriesKey changes (see
guard below). useOHLCVChart does not clear data until the new fetch resolves.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit f7a52c7. Configure here.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: None (no tests recommended)
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 90%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are confined to the AdvancedChart component (a TradingView/OHLCV charting widget used in token overview) and its unit tests. The PR fixes a race condition where stale OHLCV data was being sent to the TradingView WebView during time range switches. Key observations:

1. Scope: Only 2 files changed - the component itself and its unit tests. No controller, engine, navigation, or shared infrastructure changes.

2. Nature of change: Internal bug fix adding a stale snapshot ref (ohlcvSeriesStaleSnapshotRef) and a key prop to force WebView remounting on series key changes. This prevents stale data from being sent to TradingView during time range switches.

3. No E2E test coverage: Searching across all E2E test directories found zero references to AdvancedChart, OHLCV, TradingView, or related charting functionality. No existing E2E tests cover this feature.

4. No shared component impact: The changes don't touch TabBar, navigation, modals, confirmations, or any other shared components that could break existing E2E tests.

5. Feature flag gated: The AdvancedChart is behind a selectTokenOverviewAdvancedChartEnabled feature flag, further limiting its blast radius.

Since no E2E test tags cover this charting functionality and the changes are well-contained internal bug fixes, no E2E tags need to be run.

Performance Test Selection:
The changes fix a race condition in WebView data synchronization for the AdvancedChart component. While a key prop is added to force WebView remounting on series key changes, this is a targeted bug fix for correctness (preventing stale data), not a broad performance regression. The WebView remounting is intentional and controlled behavior. No performance test tags cover chart rendering or token overview specifically, and the change doesn't affect account lists, onboarding, login, swaps, app launch, or asset loading in a way that would meaningfully impact the measured performance metrics.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud