fix(rewards): match carousel design from perps#28940
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a7f0ba8. Configure here.
| fireEvent.press(getByText('Next')); | ||
|
|
||
| expect(getByText("Let's go")).toBeOnTheScreen(); | ||
| expect(queryByText('Next')).toBeNull(); |
There was a problem hiding this comment.
Test uses fragile text queries instead of testIDs
Low Severity
The new test uses getByText('Next') for pressing the button, while every other test in the same file uses getByTestId(CAMPAIGN_TOUR_STEP_TEST_IDS.NEXT_BUTTON) for the same action. This violates the "Element Selection - PREFER DATA TEST IDs" rule which states to always prefer testID props and avoid selecting by hardcoded text content. The CAMPAIGN_TOUR_STEP_TEST_IDS.NEXT_BUTTON constant is already available and used consistently elsewhere in this file. Additionally, expect(queryByText('Next')).toBeNull() uses a weak matcher — not.toBeOnTheScreen() is preferred per assertion guidelines.
Triggered by project rule: Unit Testing Guidelines
Reviewed by Cursor Bugbot for commit a7f0ba8. Configure here.
There was a problem hiding this comment.
Not fixing right now, will fix in another PR
|
✅ E2E Fixture Validation — Schema is up to date |
|





Description
This makes the Rewards carousel match the Perps carousel.
Changelog
CHANGELOG entry: null
Related issues
Fixes: n/a
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2026-04-16.at.2.16.11.PM.mov
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Primarily UI/layout tweaks and copy changes to the Rewards tour carousel, with a small test addition; low likelihood of impacting core app flows beyond the onboarding screen.
Overview
Aligns the Rewards campaign tour carousel UI with the Perps carousel by adjusting spacing/layout, left-aligning step text, resizing/repositioning the optional image, and restyling the footer (notably changing Skip from a secondary button to a centered text link).
Updates the primary CTA to show "Let’s go" on the last step (new
rewards.onboarding.step_finishi18n string), and adds a test to assert the final-step label swap fromNexttoLet’s go.Reviewed by Cursor Bugbot for commit a7f0ba8. Bugbot is set up for automated code reviews on this repo. Configure here.