Skip to content

fix(rewards): match carousel design from perps#28940

Merged
Montoya merged 2 commits into
mainfrom
rwds-updated-carousel
Apr 16, 2026
Merged

fix(rewards): match carousel design from perps#28940
Montoya merged 2 commits into
mainfrom
rwds-updated-carousel

Conversation

@Montoya
Copy link
Copy Markdown
Contributor

@Montoya Montoya commented Apr 16, 2026

Description

This makes the Rewards carousel match the Perps carousel.

Changelog

CHANGELOG entry: null

Related issues

Fixes: n/a

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Screen.Recording.2026-04-16.at.2.16.11.PM.mov

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Primarily UI/layout tweaks and copy changes to the Rewards tour carousel, with a small test addition; low likelihood of impacting core app flows beyond the onboarding screen.

Overview
Aligns the Rewards campaign tour carousel UI with the Perps carousel by adjusting spacing/layout, left-aligning step text, resizing/repositioning the optional image, and restyling the footer (notably changing Skip from a secondary button to a centered text link).

Updates the primary CTA to show "Let’s go" on the last step (new rewards.onboarding.step_finish i18n string), and adds a test to assert the final-step label swap from Next to Let’s go.

Reviewed by Cursor Bugbot for commit a7f0ba8. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-rewards Rewards team label Apr 16, 2026
@Montoya Montoya changed the title Update carousel fix(rewards): match carousel design from perps Apr 16, 2026
@Montoya Montoya marked this pull request as ready for review April 16, 2026 18:17
@Montoya Montoya requested a review from a team as a code owner April 16, 2026 18:17
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@Montoya Montoya enabled auto-merge April 16, 2026 18:21
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a7f0ba8. Configure here.

fireEvent.press(getByText('Next'));

expect(getByText("Let's go")).toBeOnTheScreen();
expect(queryByText('Next')).toBeNull();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test uses fragile text queries instead of testIDs

Low Severity

The new test uses getByText('Next') for pressing the button, while every other test in the same file uses getByTestId(CAMPAIGN_TOUR_STEP_TEST_IDS.NEXT_BUTTON) for the same action. This violates the "Element Selection - PREFER DATA TEST IDs" rule which states to always prefer testID props and avoid selecting by hardcoded text content. The CAMPAIGN_TOUR_STEP_TEST_IDS.NEXT_BUTTON constant is already available and used consistently elsewhere in this file. Additionally, expect(queryByText('Next')).toBeNull() uses a weak matcher — not.toBeOnTheScreen() is preferred per assertion guidelines.

Fix in Cursor Fix in Web

Triggered by project rule: Unit Testing Guidelines

Reviewed by Cursor Bugbot for commit a7f0ba8. Configure here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fixing right now, will fix in another PR

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
11 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud
Copy link
Copy Markdown

@Montoya Montoya added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit 5c26349 Apr 16, 2026
209 of 219 checks passed
@Montoya Montoya deleted the rwds-updated-carousel branch April 16, 2026 19:47
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.75.0 Issue or pull request that will be included in release 7.75.0 label Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.75.0 Issue or pull request that will be included in release 7.75.0 size-M team-rewards Rewards team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants