chore: bump @metamask/smart-transactions-controller to ^24.0.0#28943
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Handle the v24 breaking change: the controller no longer accepts a getBearerToken constructor param; it now calls AuthenticationController:getBearerToken directly through its runtime messenger. - Add AuthenticationController:getBearerToken to the STC runtime messenger's allowed actions (getSmartTransactionsControllerMessenger) - Remove getBearerToken from the SmartTransactionsController constructor call - Remove AuthenticationController:getBearerToken delegation from the init messenger and drop the AuthenticationControllerGetBearerTokenAction import from @metamask/profile-sync-controller - Wire Sentinel API auth through the runtime controllerMessenger instead of the init messenger
ea894fa to
e0e1eb3
Compare
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
|
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
nthpool
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Bumps
@metamask/smart-transactions-controllerfrom^23.0.0to^24.0.0and handles the v24 breaking change.Breaking change in v24: The
getBearerTokenconstructor parameter was removed. The controller now callsAuthenticationController:getBearerTokendirectly through its own runtime messenger.Changes made:
AuthenticationController:getBearerTokenmoved from the init messenger to the controller's runtime messenger (getSmartTransactionsControllerMessenger)getBearerTokenwrapper closure fromsmart-transactions-controller-init.tssetSentinelApiAuthstill needs the bearer token and now callscontrollerMessenger.call('AuthenticationController:getBearerToken')directlyNo behavior change — the bearer token is still fetched and sent with authenticated requests.
Changelog
CHANGELOG entry: null
Related issues
Fixes: STX-503
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
N/A — no runtime behavior change.
Pre-merge reviewer checklist
Note
Medium Risk
Touches auth token plumbing and messenger delegation for Smart Transactions/Sentinel requests; incorrect wiring could silently drop authenticated headers or break controller calls, though the change is narrowly scoped and covered by updated tests.
Overview
Updates
@metamask/smart-transactions-controllerto^24.0.0and adjusts the engine integration for the v24 breaking change that removes the controller constructor’sgetBearerTokenoption.AuthenticationController:getBearerTokendelegation is moved to the Smart Transactions runtime messenger, and init-time delegation is removed;smart-transactions-controller-initnow configures Sentinel auth viasetSentinelApiAuthusing a token getter that callscontrollerMessenger.call('AuthenticationController:getBearerToken'). Unit tests are updated to assert the new constructor signature and to validate Sentinel auth setup/token retrieval behavior.Reviewed by Cursor Bugbot for commit e0e1eb3. Bugbot is set up for automated code reviews on this repo. Configure here.