chore(rewards): Ondo campaign UI audit

[sophieqgu]

Description

Small fixes

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: None (no tests recommended)
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 92%

click to see 🤖 AI reasoning details

E2E Test Selection:
All 24 changed files are confined to the Rewards feature UI components and locale string files. The changes are:

1. Rewards UI components (OndoCampaignDetailsView, CampaignStatsSummary, OndoLeaderboard, RewardsReferralView, CopyableField, RewardSettingsAccountGroup): These are minor UI-only changes — adding a testID, removing an unused showHeader prop, removing a trailing period from rank display, removing an error banner, adjusting padding/spacing, changing button sizes, and refactoring layout. No business logic, navigation, or shared component changes.

2. Locale files (14 languages): Minor text changes — capitalization fixes ("Prize Pool" → "Prize pool", "Market Value" → "Market value") and a rewording of the referral description. These don't affect functionality.

No E2E tests exist for the Rewards feature — searching the tests/ directory found no test files covering OndoCampaign, RewardsReferral, CampaignStats, or OndoLeaderboard. The Rewards feature is not covered by any of the available E2E test tags.

No shared/critical components are affected: No TabBar, navigation stack, modals, confirmations, or any other cross-cutting component was modified. No controllers, Engine, or core infrastructure was touched.

Risk assessment: Low risk. These are isolated UI polish changes in a feature area with no existing E2E coverage. Running any test suite would not validate these specific changes, and the changes pose no risk to other tested flows.

Performance Test Selection:
No performance-sensitive code paths were modified. All changes are minor UI styling adjustments (padding, button sizes, layout) and locale string updates in the Rewards feature. These changes do not affect rendering performance, data loading, state management, or any critical user flows measured by performance tests.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud