Skip to content

feat: onboarding analytics e2e tests#28962

Draft
grvgoel81 wants to merge 33 commits into
mainfrom
feat/onboarding-analytics-e2e-tests
Draft

feat: onboarding analytics e2e tests#28962
grvgoel81 wants to merge 33 commits into
mainfrom
feat/onboarding-analytics-e2e-tests

Conversation

@grvgoel81
Copy link
Copy Markdown
Contributor

@grvgoel81 grvgoel81 commented Apr 17, 2026

Description

  • Adds a smoke E2E test that asserts MetaMetrics payloads for Google seedless new-user onboarding, using the same analyticsExpectations pattern as wallet import tests.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: seedless onboarding analytics E2E

  Scenario: developer runs the new smoke test locally
    Given Metro is running with e2e + seedless + mock OAuth env and an E2E build is installed

    When the user runs the Detox suite for google-login-analytics
    Then MetaMetrics events for social Google new-user onboarding are asserted and the test passes

Screenshots/Recordings

Before

After

Screenshot 2026-04-17 at 11 48 45 AM

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Medium risk because it changes seedless OAuth onboarding behavior (wallet setup + mock OAuth path) and modifies E2E network/proxy and Android network-security config, which could impact test stability and OAuth onboarding if misconfigured.

Overview
Adds a new seedless Google social login analytics smoke test that asserts expected MetaMetrics events via the existing analyticsExpectations pattern.

Updates E2E OAuth mocking to be closer to production: E2E_MOCK_OAUTH now still runs seedless authenticate and seed phrase backup for OAuth flows, introduces OAUTH_BUILD_TYPE env override + centralized build-type mapping, and generates/caches unique mock emails for QA token exchange (with optional launch-arg/env overrides).

Hardens E2E infra: routes only OAuthLoginHandlers through Metro mocks (no Seedless controller mocking), bypasses the mock proxy for Web3Auth/auth-service hosts, expands the E2E allowlist accordingly, filters hop-by-hop headers in the mock server, and adds Android network-security-config trust anchors. Also adds accessibility labels for password fields to stabilize Android Detox selectors and includes a new seedless change-password smoke test.

Reviewed by Cursor Bugbot for commit 03bfd76. Configure here.

@grvgoel81 grvgoel81 self-assigned this Apr 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-onboarding Onboarding team label Apr 17, 2026
@grvgoel81 grvgoel81 force-pushed the feat/onboarding-analytics-e2e-tests branch from 71491d4 to 02d0aae Compare April 22, 2026 06:51
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@grvgoel81 grvgoel81 marked this pull request as ready for review April 29, 2026 08:42
@grvgoel81 grvgoel81 requested review from a team as code owners April 29, 2026 08:42
@grvgoel81 grvgoel81 marked this pull request as draft April 29, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant