chore: integrate authenticated user storage package

[zone-live]

Description

Wires AuthenticatedUserStorageService into the Engine (messenger, init, types, constants) and refactors useNotificationPreferences to persist SocialAI preferences remotely.

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-04-22.at.13.20.17.mov

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Medium risk because it adds a new Engine service/messenger and changes notification-preferences persistence to remote read/merge/write with optimistic UI updates, which could impact user settings if the integration is incorrect.

Overview
Adds remote persistence for Social Leaderboard notification preferences. useNotificationPreferences is refactored from local state to an account-scoped useQuery read plus serialized read/merge/write PUTs via Engine.controllerMessenger to AuthenticatedUserStorageService, using a muted-trader opt-out list (mutedTraderProfileIds) and optimistic overlays with rollback/error handling and cache priming.

Wires AuthenticatedUserStorageService into the app runtime. Engine now initializes the service (hardcoded prod environment), adds a dedicated messenger delegating AuthenticationController:getBearerToken, and updates Engine types/constants plus DATA_SERVICES; package dependency is added.

Improves Notification Preferences UI stability and tests. The view shows a new PreferencesSkeleton while remote prefs load (avoids toggle flash), caches currency Intl.NumberFormat instances, updates selector IDs/localized title casing, and rewrites/extends tests to cover loading, muted traders, and hook-driven interactions.

^{Reviewed by Cursor Bugbot for commit a17c632. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​@​metamask/​authenticated-user-storage@​1.0.0

View full report

[zone-live]

@SocketSecurity ignore npm/@metamask/authenticated-user-storage@1.0.0.

[zone-live]

@SocketSecurity ignore npm/@metamask/authenticated-user-storage@1.0.0

[Copilot]

Pull request overview

Integrates @metamask/authenticated-user-storage into the Engine and refactors Social Leaderboard notification preferences to persist remotely via the new service.

Changes:

• Adds AuthenticatedUserStorageService messenger + init wiring (Engine types, constants, factories, tests).
• Refactors useNotificationPreferences to a remote GET/PUT flow with optimistic UI overlay and serialized writes.
• Updates Notification Preferences UI to show a preferences-loading skeleton and adjusts tests/strings accordingly.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
yarn.lock	Locks @metamask/authenticated-user-storage@^1.0.0 and dependencies.
package.json	Adds @metamask/authenticated-user-storage dependency.
locales/languages/en.json	Capitalizes notification preferences title string.
babel.config.tests.js	Excludes new init files from env var inlining in tests.
app/core/Engine/types.ts	Registers new service types/actions/events in Engine typing.
app/core/Engine/messengers/index.ts	Adds messenger factory entry for the new service.
app/core/Engine/messengers/authenticated-user-storage-service-messenger.ts	Creates restricted messenger delegating bearer token access.
app/core/Engine/messengers/authenticated-user-storage-service-messenger.test.ts	Basic messenger creation test.
app/core/Engine/controllers/authenticated-user-storage-service-init.ts	Initializes the service (environment pinned to prod).
app/core/Engine/controllers/authenticated-user-storage-service-init.test.ts	Tests init and environment selection.
app/core/Engine/constants.ts	Marks service as stateless/non-controller.
app/core/Engine/Engine.ts	Wires service initialization and exposure on Engine.context.
app/components/Views/SocialLeaderboard/NotificationPreferencesView/hooks/useNotificationPreferences.ts	Replaces local state with remote read/merge/write persistence + optimistic overlay.
app/components/Views/SocialLeaderboard/NotificationPreferencesView/hooks/useNotificationPreferences.test.ts	Adds/updates tests for new remote persistence behavior.
app/components/Views/SocialLeaderboard/NotificationPreferencesView/hooks/index.ts	Updates exported types to SocialAIPreference.
app/components/Views/SocialLeaderboard/NotificationPreferencesView/components/Skeletons.tsx	Adds PreferencesSkeleton for preference-loading state.
app/components/Views/SocialLeaderboard/NotificationPreferencesView/NotificationPreferencesView.tsx	Consumes new hook API, shows skeleton, caches currency formatter.
app/components/Views/SocialLeaderboard/NotificationPreferencesView/NotificationPreferencesView.testIds.ts	Adds test id for preferences-loading skeleton.
app/components/Views/SocialLeaderboard/NotificationPreferencesView/NotificationPreferencesView.test.tsx	Updates tests for new hook + skeleton behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

AI PR Analysis

🚫 Merge safe: false | 🟠 Risk: high

Merge decision: AI analysis did not complete — manual review required before merging.

AI analysis did not complete. Manual review recommended.

View run

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeWalletPlatform, SmokeNetworkAbstractions, SmokeConfirmations, SmokeAccounts
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 72%

click to see 🤖 AI reasoning details

E2E Test Selection:

Analysis

Engine Changes (Critical Files)

The PR adds a new AuthenticatedUserStorageService to the Engine:

• Engine.ts: Adds authenticatedUserStorageServiceInit to the controller init map and messengerClientsByName extraction
• constants.ts: Adds AuthenticatedUserStorageService to STATELESS_NON_CONTROLLER_NAMES (stateless, no Redux sync needed)
• types.ts: Adds type definitions for the new service
• messengers/index.ts: Registers new messenger factory
• messengers/authenticated-user-storage-service-messenger.ts: New messenger delegating AuthenticationController:getBearerToken

Risk Assessment: These are purely additive changes. No existing controllers are modified, no initialization order changes, no breaking messenger changes. The new service is Phase 6 (feature-level), not Phase 2 (critical). However, since Engine.ts is modified, there's a risk that the new package (@metamask/authenticated-user-storage) could cause initialization failures that would break all features.

Feature Changes (SocialLeaderboard)

• useNotificationPreferences hook refactored from local state to AuthenticatedUserStorageService persistence
• Added PreferencesSkeleton loading state
• Changed notification semantics (opt-in → opt-out)
• data-services.ts updated to include the new service in ReactQuery

The SocialLeaderboard/NotificationPreferences feature is part of the Trending tab, which is covered by SmokeWalletPlatform.

package.json

New @metamask/authenticated-user-storage: ^1.0.0 dependency added. This is a new package that could potentially affect app startup if it has issues.

Tag Selection Rationale

1. SmokeWalletPlatform: The SocialLeaderboard/NotificationPreferences feature is part of the Trending tab. Also covers wallet lifecycle and general platform health to verify Engine initialization still works.
2. SmokeNetworkAbstractions: Covers notification settings flows (explicitly mentioned in tag description). Also validates Engine initialization for network-dependent features.
3. SmokeConfirmations: Engine initialization validation - if the new service causes Engine startup issues, transaction confirmations would fail. Important smoke test for Engine health.
4. SmokeAccounts: The new service uses AuthenticationController:getBearerToken which is tied to authentication/account state. Account tests verify the auth chain still works.

No performance tests needed - the changes are additive service registration and a UI loading skeleton, not performance-critical paths.

Performance Test Selection:
No performance tests needed. The changes are: (1) additive Engine service registration (stateless, no Redux sync), (2) UI loading skeleton for notification preferences, and (3) hook refactoring from local state to remote storage. None of these changes affect critical performance paths like account list rendering, app launch, login, swaps, or asset loading. The new service is a stateless helper that only activates when the NotificationPreferences screen is opened.

View GitHub Actions results

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit a17c632. Configure here.}

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
92.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details